[ 
https://issues.apache.org/jira/browse/PHOENIX-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17091351#comment-17091351
 ] 

Hadoop QA commented on PHOENIX-5789:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/13001056/PHOENIX-5789.master.addendum.v2.patch
  against master branch at commit 0b3c8a378a2ebb7cbbb6bcc3e6b308c37da1e358.
  ATTACHMENT ID: 13001056

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3787//console

This message is automatically generated.

> try to standardize on a JSON library
> ------------------------------------
>
>                 Key: PHOENIX-5789
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5789
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: core
>            Reporter: Istvan Toth
>            Assignee: Richard Antal
>            Priority: Minor
>         Attachments: PHOENIX-5789.4.x.v1.patch, PHOENIX-5789.4.x.v3.patch, 
> PHOENIX-5789.4.x.v4.patch, PHOENIX-5789.4.x.v5.patch, 
> PHOENIX-5789.4.x.v6.patch, PHOENIX-5789.4.x.v7.patch, 
> PHOENIX-5789.master.addendum.patch, PHOENIX-5789.master.addendum.v2.patch, 
> PHOENIX-5789.master.v1.patch, PHOENIX-5789.master.v2.patch, 
> PHOENIX-5789.master.v3.patch, PHOENIX-5789.master.v4.patch
>
>
> Phoenix uses at least the following JSON libraries:
>  * gson
>  * jackson
>  * jettison
> Of these, only the jackson usage is performance critical, as it is used 
> during bulk loading. 
> Try to standardize on a single one to reduce dependency hell.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to