gjacoby126 commented on a change in pull request #768:
URL: https://github.com/apache/phoenix/pull/768#discussion_r414839188
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java
##########
@@ -1887,6 +1899,13 @@ public boolean isImmutableRows() {
return immutableRows;
}
+ public boolean isViewIndex() {
+ if (parentTableType == null) {
Review comment:
@sguggilam - In the upgrade scenario where the clients don't have the
new proto and hence parentTableType isn't defined, will this still work OK to
have isViewIndex incorrectly return true?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
