[
https://issues.apache.org/jira/browse/PHOENIX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105586#comment-17105586
]
Josh Elser edited comment on PHOENIX-5842 at 5/12/20, 4:43 PM:
---------------------------------------------------------------
{noformat}
+ <id>codecoverage</id>
+ <activation>
+ <property>
+ <name>code.coverage</name>
+ <value>!deactivate</value>
+ </property>
+ </activation>{noformat}
Why the {{!deactivate}} value? Does this actually work as you expect, or is
this expecting a literal "!deactivate" value?
If you dont' want this activated by default, wouldn't it be easier to default
activation by the absence of a system property, e.g. {{-Dskip.code-coverage}}
or similar?
{code}
<property>
<name>!skip.code-coverage</name>
</property>
{code}
Please don't forget to update build documentation so people know how to use
this.
was (Author: elserj):
{noformat}
+ <id>codecoverage</id>
+ <activation>
+ <property>
+ <name>code.coverage</name>
+ <value>!deactivate</value>
+ </property>
+ </activation>{noformat}
Why the {{!deactive}} value? Does this actually work as you expect, or is this
expecting a literal "!deactivate" value?
If you dont' want this activated by default, wouldn't it be easier to default
activation by the absence of a system property, e.g. {{-Dskip.code-coverage}}
or similar?
{code}
<property>
<name>!skip.code-coverage</name>
</property>
{code}
Please don't forget to update build documentation so people know how to use
this.
> Code Coverage tool for Phoenix
> ------------------------------
>
> Key: PHOENIX-5842
> URL: https://issues.apache.org/jira/browse/PHOENIX-5842
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0, 4.14.3
> Reporter: Sandeep Guggilam
> Assignee: Sandeep Guggilam
> Priority: Major
> Labels: quality-improvement
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5842.4.x.v1.patch, PHOENIX-5842.4.x.v2.patch,
> PHOENIX-5842.master.v1.patch, PHOENIX-5842_addendum.patch
>
>
> Currently we don't have any code coverage tool for Phoenix. This is required
> for us to measure the test coverage and helps us in improving the test suite
> further till we reach may be 80% coverage
> The test coverage results can also be integrated into the Hadoop QA run of
> the precommit build such that the reviewers could take a look at the report
> and see if the added code doesn't have enough coverage
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
