[
https://issues.apache.org/jira/browse/PHOENIX-5842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17105609#comment-17105609
]
Sandeep Guggilam commented on PHOENIX-5842:
-------------------------------------------
> Why the {{!deactivate}} value? Does this actually work as you expect, or is
> this expecting a literal "!deactivate" value?
Yes [~elserj] , the idea is to give the ability to skip code coverage by
giving "-Dcode.coverage=deactivate" but your suggestion for just checking the
absence of system property is more intuitive in usage as well. Shall make the
change in the addendum patch
> Please don't forget to update build documentation so people know how to use
> this.
Sure
> Code Coverage tool for Phoenix
> ------------------------------
>
> Key: PHOENIX-5842
> URL: https://issues.apache.org/jira/browse/PHOENIX-5842
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0, 4.14.3
> Reporter: Sandeep Guggilam
> Assignee: Sandeep Guggilam
> Priority: Major
> Labels: quality-improvement
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5842.4.x.v1.patch, PHOENIX-5842.4.x.v2.patch,
> PHOENIX-5842.master.v1.patch, PHOENIX-5842_addendum.patch
>
>
> Currently we don't have any code coverage tool for Phoenix. This is required
> for us to measure the test coverage and helps us in improving the test suite
> further till we reach may be 80% coverage
> The test coverage results can also be integrated into the Hadoop QA run of
> the precommit build such that the reviewers could take a look at the report
> and see if the added code doesn't have enough coverage
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
