[
https://issues.apache.org/jira/browse/PHOENIX-5875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110825#comment-17110825
]
Hadoop QA commented on PHOENIX-5875:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13003332/PHOENIX-5875-4.x.v1.patch
against 4.x branch at commit 49599fd89b6cfa9cab9d7d3f6dcf4bdc5428915a.
ATTACHMENT ID: 13003332
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 10 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ IndexTool.IndexDisableLoggingType.BEFORE, null, schemaName,
dataTableName, indexTableName,
+ truncateTable(conn,
TableName.valueOf(IndexVerificationOutputRepository.OUTPUT_TABLE_NAME));
+ Long.toString(EnvironmentEdgeManager.currentTimeMillis()),"-dl",
disableLoggingType.toString());
+ private static List<String> getArgList (boolean directApi, boolean
useSnapshot, String schemaName,
+ IndexTool.IndexDisableLoggingType disableLoggingVerifyType =
IndexTool.IndexDisableLoggingType.BEFORE;
+ IndexTool.IndexDisableLoggingType disableLoggingVerifyType =
IndexTool.IndexDisableLoggingType.AFTER;
+ IndexTool.IndexDisableLoggingType disableLoggingVerifyType =
IndexTool.IndexDisableLoggingType.BOTH;
+ IndexTool.IndexDisableLoggingType disableLoggingVerifyType =
IndexTool.IndexDisableLoggingType.NONE;
+ public void verifyDisableLogging(IndexTool.IndexDisableLoggingType
disableLoggingVerifyType, boolean expectedBefore, boolean expectedAfter) throws
SQLException, IOException {
+ private IndexTool.IndexDisableLoggingType disableLoggingVerifyType =
IndexTool.IndexDisableLoggingType.NONE;
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.LocalMutableNonTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinLocalIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.util.IndexScrutinyIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexWithTableSchemaChangeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.SubqueryUsingSortMergeJoinIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3869//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3869//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3869//console
This message is automatically generated.
> Optional logging for IndexTool verification
> -------------------------------------------
>
> Key: PHOENIX-5875
> URL: https://issues.apache.org/jira/browse/PHOENIX-5875
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.14.3
> Reporter: Kadir OZDEMIR
> Assignee: Geoffrey Jacoby
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5875-4.x.v1.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> IndexTool logs information about each row that has a verification failure.
> The amount of logging can be excessive for large index tables. Also for some
> runs, we may want to just do incremental repair, i.e., repair only the rows
> that are broken, using -v BOTH or -v BEFORE, but not interested in the
> details of how they are broken. Thus, IndexTool should have an option to
> disable logging, something like, -dl (--disable-logging) BEFORE | AFTER |
> BOTH where BEFORE, AFTER and BOTH indicate at the which phase (before or
> after index repair or a both phases ) logging is disabled.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
