[
https://issues.apache.org/jira/browse/PHOENIX-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113767#comment-17113767
]
Hadoop QA commented on PHOENIX-5910:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13003700/PHOENIX-5910.4.x.002.patch
against 4.x branch at commit aad583670ea821286ab5e2460ce0ab7255d474c4.
ATTACHMENT ID: 13003700
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 0 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_UNVERIFIED_INDEX_ROW_COUNT).getValue());
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_OLD_INDEX_ROW_COUNT).getValue());
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_UNKNOWN_INDEX_ROW_COUNT).getValue());
+ IndexTool indexTool = IndexToolIT.runIndexTool(true, false, "",
dataTableName, indexTableName, null, 0, IndexTool.IndexVerifyType.ONLY);
+ assertEquals(3,
indexTool.getJob().getCounters().findCounter(SCANNED_DATA_ROW_COUNT).getValue());
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(REBUILT_INDEX_ROW_COUNT).getValue());
+ assertEquals(3,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_VALID_INDEX_ROW_COUNT).getValue());
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_EXPIRED_INDEX_ROW_COUNT).getValue());
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_INVALID_INDEX_ROW_COUNT).getValue());
+ assertEquals(0,
indexTool.getJob().getCounters().findCounter(BEFORE_REBUILD_MISSING_INDEX_ROW_COUNT).getValue());
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinGlobalIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexSplitReverseScanIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.LocalImmutableNonTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.rpc.UpdateCacheConnectionLevelPropIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.SortMergeJoinNoIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.replication.SystemCatalogWALEntryFilterIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DropTableWithViewsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.txn.RollbackIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.SortMergeJoinGlobalIndexIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3886//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3886//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3886//console
This message is automatically generated.
> IndexTool verification-only runs should have counters for unverified rows
> -------------------------------------------------------------------------
>
> Key: PHOENIX-5910
> URL: https://issues.apache.org/jira/browse/PHOENIX-5910
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.14.3
> Reporter: Kadir OZDEMIR
> Assignee: Kadir OZDEMIR
> Priority: Major
> Attachments: PHOENIX-5910.4.x.001.patch, PHOENIX-5910.4.x.002.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> An index row is considered unverified if the empty column value does not
> exist or has a value other than "verified". Although an unverified index row
> can be repaired and if so, it is considered a valid row, it is desirable to
> have counters for the unverified rows and report them during IndexTool
> only-verification runs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
