[ 
https://issues.apache.org/jira/browse/PHOENIX-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17114459#comment-17114459
 ] 

Hadoop QA commented on PHOENIX-5909:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/13003786/PHOENIX-5909-4.x-v1.patch
  against 4.x branch at commit aad583670ea821286ab5e2460ce0ab7255d474c4.
  ATTACHMENT ID: 13003786

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +        props.put(QueryServices.TASK_HANDLING_INITIAL_DELAY_MS_ATTRIB, 
Long.toString(Long.MAX_VALUE));
+        
verifyCounter(getTableCounterName(MetricsIndexerSource.POST_INDEX_UPDATE_FAILURE),
 registry);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.LocalImmutableTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.tx.TxCheckpointIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinGlobalIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.SubqueryUsingSortMergeJoinIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.join.HashJoinMoreIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.salted.SaltedTableVarLengthRowKeyIT

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3889//testReport/
Code Coverage results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3889//artifact/phoenix-core/target/site/jacoco/index.html
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3889//console

This message is automatically generated.

> Table and index-level metrics for indexing coprocs
> --------------------------------------------------
>
>                 Key: PHOENIX-5909
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5909
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Major
>             Fix For: 5.1.0, 4.16.0
>
>         Attachments: PHOENIX-5909-4.x-v1.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> For many of the metrics which the IndexRegionObserver and GlobalIndexChecker 
> coprocs expose, it would be useful to have them broken down by table or 
> index, in addition to the current aggregates by region server. This would 
> help us determine if, for example, a flood of read repairs was coming from 
> one particular index. 
> Thanks [~priyankporwal] for the feature suggestion. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to