[
https://issues.apache.org/jira/browse/PHOENIX-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17115870#comment-17115870
]
Hadoop QA commented on PHOENIX-5884:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13003908/PHOENIX-5884.master.v5.patch
against master branch at commit aad583670ea821286ab5e2460ce0ab7255d474c4.
ATTACHMENT ID: 13003908
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ +
"('201905','ID2_VAL','ID3_VAL','01','000000','ID4_VAL','ID5_VAL','2019-12-31
22:59:59.000') \n"
+ +
"('201905','ID2_VAL','ID3_VAL','30','000000','ID4_VAL','ID5_VAL','2019-12-31
22:59:59.000') \n"
+ +
"('201904','ID2_VAL','ID3_VAL2','01','000000','ID4_VAL','ID5_VAL','2019-05-30
22:41:37.000')\n"
+ +
"('201905','ID2_VAL','ID3_VAL2','30','000000','ID4_VAL','ID5_VAL','2019-12-31
22:59:59.000')";
+ isFixedWidthAtEnd = table.getPKColumns().get(pkPos +
minSpan -1).getDataType().isFixedWidth();
+ isFixedWidthAtEnd =
table.getPKColumns().get(otherPKPos + otherMinSpan
-1).getDataType().isFixedWidth();
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3893//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3893//artifact/phoenix-core/target/site/jacoco/index.html
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3893//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3893//console
This message is automatically generated.
> Join query return empty result when filters for both the tables are present
> ---------------------------------------------------------------------------
>
> Key: PHOENIX-5884
> URL: https://issues.apache.org/jira/browse/PHOENIX-5884
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.0
> Reporter: Ankit Singhal
> Assignee: Ankit Singhal
> Priority: Major
> Attachments: PHOENIX-5884.master.v2.patch,
> PHOENIX-5884.master.v3.patch, PHOENIX-5884.master.v4.patch,
> PHOENIX-5884.master.v5.patch, PHOENIX-5884_v1.patch
>
>
> Let's assume DDL to be same for both the tables involved in a join
> {code}
> CREATE TABLE LeftTable ( id1 CHAR(6) NOT NULL, id2 VARCHAR(22) NOT
> NULL, id3 VARCHAR(12) NOT NULL, id4 CHAR(2) NOT NULL, id5 CHAR(6)
> NOT NULL, id6 VARCHAR(200) NOT NULL, id7 VARCHAR(50) NOT NULL, ts
> TIMESTAMP , CONSTRAINT PK_JOIN_AND_INTERSECTION_TABLE PRIMARY
> KEY(id1,id2,id3,id4,id5,id6,id7))
> {code}
> Following query return right results
> {code}
> SELECT m.*,r.* FROM LEFT_TABLE m join RIGHT_TABLE r on m.id3 = r.id3 and
> m.id2 = r.id2 and m.id4 = r.id4 and m.id5 = r.id5 and m.id1 = r.id1 and
> m.ts = r.ts where r.id1 IN ('201904','201905') and r.id2 = 'ID2_VAL' and
> r.id3 IN ('ID3_VAL','ID3_VAL2')
> {code}
> but When to optimize the query, filters for the left table are also added ,
> query returned empty result . Though the filters are based on join condition
> so semantically above query and below query should be same.
> {code}
> SELECT m.*,r.* FROM LEFT_TABLE m join RIGHT_TABLE r on m.id3 = r.id3 and
> m.id2 = r.id2 and m.id4 = r.id4 and m.id5 = r.id5 and m.id1 = r.id1 and
> m.ts = r.ts where m.id1 IN ('201904','201905') and r.id1 IN
> ('201904','201905') and r.id2 = 'ID2_VAL' and m.id3 IN
> ('ID3_VAL','ID3_VAL2') and r.id3 IN ('ID3_VAL','ID3_VAL2')
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
