[
https://issues.apache.org/jira/browse/PHOENIX-5905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123911#comment-17123911
]
Hadoop QA commented on PHOENIX-5905:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13004620/PHOENIX-5905.master.addendum2.patch
against master branch at commit 02047c0a25e9375b43679c690d45d51a4ba8ba2d.
ATTACHMENT ID: 13004620
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 0 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ static void initCluster(boolean isNamespaceMapped, boolean
useCustomAccessController) throws Exception {
+
RpcCallback<AccessControlProtos.GetUserPermissionsResponse> done) {
+ final String userName = request.hasUserName() ?
request.getUserName().toStringUtf8() : null;
+ request.hasNamespaceName() ?
request.getNamespaceName().toStringUtf8() : null;
+ request.hasTableName() ?
ProtobufUtil.toTableName(request.getTableName()) : null;
+ request.hasColumnQualifier() ?
request.getColumnQualifier().toByteArray() : null;
+ getUserPermissionsRequest =
GetUserPermissionsRequest.newBuilder(table).withFamily(cf)
+
GetUserPermissionsRequest.newBuilder(namespace).withUserName(userName).build();
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3919//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3919//artifact/phoenix-core/target/site/jacoco/index.html
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3919//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/3919//console
This message is automatically generated.
> Reset user to hbase by changing rpc context before getting user permissions
> on access controller service
> ---------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-5905
> URL: https://issues.apache.org/jira/browse/PHOENIX-5905
> Project: Phoenix
> Issue Type: Bug
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Rajeshbabu Chintaguntla
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5905.master.addendum2.patch, PHOENIX-5905.patch,
> PHOENIX-5905_addendum.patch, PHOENIX-5905_addendum2.patch
>
>
> Currently we are calling getUserPermissions with hbase user directly on
> access controller service which is not a rpc call. If we don't reset user
> system user will be considered and might expect extra privileges to return
> the user permissions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
