stoty commented on a change in pull request #35:
URL: https://github.com/apache/phoenix-queryserver/pull/35#discussion_r434402818
##########
File path: bin/queryserver.py
##########
@@ -121,12 +119,11 @@
# " -XX:+UnlockCommercialFeatures -XX:+FlightRecorder
-XX:FlightRecorderOptions=defaultrecording=true,dumponexit=true" + \
# The command is run through subprocess so environment variables are
automatically inherited
-java_cmd = '%(java)s -cp ' + hbase_config_path + os.pathsep +
hadoop_config_path + os.pathsep + \
+java_cmd = '%(java)s -cp ' + hbase_config_path + os.pathsep + \
Review comment:
No, the Hadoop config is also is also used by all Hadoop clients, i.e.
anything that uses HDFS, MR, etc.
HBase is designed to work on top of Hadoop, and uses many of its features.
It needs the Hadoop config even for its clients.
One example is the proxyuser settings that are defined in the Hadoop config
files, and HBase and Phoenix both need to access those.
The Phoenix client also uses HDFS directly (at least for loading UDF jars),
so its needs to have access to all HDFS settings as well.
I am sure that there are plenty of other cases where HBase (client) and
Phoenix need to have access to the full Hadoop config, the above two are just
the ones that have caused problems for me personally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
