[
https://issues.apache.org/jira/browse/PHOENIX-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206339#comment-17206339
]
Hadoop QA commented on PHOENIX-5839:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
38s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} 4.x Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
27s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
26s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
14s{color} | {color:green} 4.x passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
28s{color} | {color:blue} phoenix-hbase-compat-1.5.0 in 4.x has 3 extant
spotbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
25s{color} | {color:blue} phoenix-hbase-compat-1.4.0 in 4.x has 3 extant
spotbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
21s{color} | {color:blue} phoenix-hbase-compat-1.3.0 in 4.x has 3 extant
spotbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
2s{color} | {color:blue} phoenix-core in 4.x has 957 extant spotbugs warnings.
{color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
44s{color} | {color:red} root: The patch generated 11 new + 223 unchanged - 16
fixed = 234 total (was 239) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} spotbugs {color} | {color:green} 5m
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}131m 26s{color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
58s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}163m 5s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | phoenix.end2end.OrphanViewToolIT |
| | phoenix.end2end.index.IndexAsyncThresholdIT |
| | phoenix.end2end.ConcurrentMutationsExtendedIT |
| | TEST-[QueryIT_0] |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/63/artifact/patchprocess/Dockerfile
|
| JIRA Issue | PHOENIX-5839 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13000153/PHOENIX-5839.4.x.v1.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux 79f39fdbe710 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 955047a |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/63/artifact/patchprocess/diff-checkstyle-root.txt
|
| unit |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/63/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/63/testReport/ |
| Max. process+thread count | 6870 (vs. ulimit of 30000) |
| modules | C: phoenix-hbase-compat-1.5.0 phoenix-hbase-compat-1.4.0
phoenix-hbase-compat-1.3.0 phoenix-core U: . |
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/63/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> CompatUtil#setStopRow semantics problem
> ---------------------------------------
>
> Key: PHOENIX-5839
> URL: https://issues.apache.org/jira/browse/PHOENIX-5839
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 4.x
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-5839.4.x.v1.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As noticed by [~gjacoby] , the semantics of the CompatUtil#setStopRow method
> are incorrect for HBase 1.3. Specifically, we invert the semantics of the
> *inclusive* flag.
> Due to the quirks of the HBase 1.3 scan semantics, the resulting behaviour in
> the specific cases where it used is correct (in fact this behaviour is needed
> for correct operation), but when used outside this specific use case (single
> row scan), it would cause problems.
> Find some other solution that solves the backwards compatibility problem, and
> does not invert the semantics of the call in the range (not single row) scan
> case.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
