stoty commented on pull request #908: URL: https://github.com/apache/phoenix/pull/908#issuecomment-703057600
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ 4.x Compile Tests _ | | +1 :green_heart: | mvninstall | 9m 5s | 4.x passed | | +1 :green_heart: | compile | 1m 1s | 4.x passed | | +1 :green_heart: | checkstyle | 1m 50s | 4.x passed | | +1 :green_heart: | javadoc | 0m 46s | 4.x passed | | +0 :ok: | spotbugs | 3m 25s | phoenix-core in 4.x has 957 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 6s | the patch passed | | +1 :green_heart: | compile | 0m 59s | the patch passed | | +1 :green_heart: | javac | 0m 59s | the patch passed | | -1 :x: | checkstyle | 1m 56s | phoenix-core: The patch generated 12 new + 3504 unchanged - 0 fixed = 3516 total (was 3504) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 45s | the patch passed | | -1 :x: | spotbugs | 3m 28s | phoenix-core generated 1 new + 957 unchanged - 0 fixed = 958 total (was 957) | ||| _ Other Tests _ | | -1 :x: | unit | 136m 37s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 38s | The patch does not generate ASF License warnings. | | | | 169m 0s | | | Reason | Tests | |-------:|:------| | FindBugs | module:phoenix-core | | | Found reliance on default encoding in org.apache.phoenix.util.UpgradeUtil.updateViewIndexIdColumnDataTypeFromShortToLongIfNeeds(PhoenixConnection, HBaseAdmin):in org.apache.phoenix.util.UpgradeUtil.updateViewIndexIdColumnDataTypeFromShortToLongIfNeeds(PhoenixConnection, HBaseAdmin): String.getBytes() At UpgradeUtil.java:[line 2267] | | Failed junit tests | phoenix.end2end.join.HashJoinGlobalIndexIT | | | phoenix.end2end.index.MutableIndexSplitReverseScanIT | | | phoenix.end2end.index.IndexMaintenanceIT | | | phoenix.end2end.BackwardCompatibilityIT | | | phoenix.end2end.IndexToolTimeRangeIT | | | phoenix.end2end.DerivedTableIT | | | phoenix.end2end.index.GlobalMutableNonTxIndexWithLazyPostBatchWriteIT | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-908/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/908 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 8a8efb6d87f9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 3ccf9a0 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-908/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-908/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-908/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-908/1/testReport/ | | Max. process+thread count | 7096 (vs. ulimit of 30000) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-908/1/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
