[ https://issues.apache.org/jira/browse/PHOENIX-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213504#comment-17213504 ]
ASF GitHub Bot commented on PHOENIX-6178: ----------------------------------------- joshelser commented on a change in pull request #918: URL: https://github.com/apache/phoenix/pull/918#discussion_r504334553 ########## File path: dev/create-release/do-release-docker.sh ########## @@ -0,0 +1,344 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# +# Creates a Phoenix release candidate. The script will update versions, tag the branch, +# build Phoenix binary packages and documentation, and upload maven artifacts to a staging +# repository. There is also a dry run mode where only local builds are performed, and +# nothing is uploaded to the ASF repos. +# +# Run with "-h" for options. For example, running below will do all +# steps above using the 'rm' dir under Downloads as workspace: +# +# $ ./do-release-docker.sh -d ~/Downloads/rm +# +# The scripts in this directory came originally from spark [1]. They were then +# modified to suite the hbase context, which were further adopted to Phoenix. +# These scripts supercedes the old +# ../make_rc.sh script for making release candidates because what is here is more +# comprehensive doing more steps of the RM process as well as running in a +# container so the RM build environment can be a constant. +# +# It: +# * Tags release +# * Sets version to the release version +# * Sets version to next SNAPSHOT version. +# * Builds, signs, and hashes all artifacts. +# * Pushes release tgzs to the dev dir in a apache dist. +# * Pushes to repository.apache.org staging. +# +# The entry point is here, in the do-release-docker.sh script. +# +# 1. https://github.com/apache/spark/tree/master/dev/create-release +# +set -e + +# Set this to build other phoenix repos: e.g. PROJECT=phoenix-connectors Review comment: Should be in README.txt? ########## File path: dev/create-release/do-release-docker.sh ########## @@ -0,0 +1,344 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# +# Creates a Phoenix release candidate. The script will update versions, tag the branch, +# build Phoenix binary packages and documentation, and upload maven artifacts to a staging +# repository. There is also a dry run mode where only local builds are performed, and +# nothing is uploaded to the ASF repos. +# +# Run with "-h" for options. For example, running below will do all +# steps above using the 'rm' dir under Downloads as workspace: +# +# $ ./do-release-docker.sh -d ~/Downloads/rm +# +# The scripts in this directory came originally from spark [1]. They were then +# modified to suite the hbase context, which were further adopted to Phoenix. +# These scripts supercedes the old +# ../make_rc.sh script for making release candidates because what is here is more +# comprehensive doing more steps of the RM process as well as running in a +# container so the RM build environment can be a constant. +# +# It: +# * Tags release +# * Sets version to the release version +# * Sets version to next SNAPSHOT version. +# * Builds, signs, and hashes all artifacts. +# * Pushes release tgzs to the dev dir in a apache dist. +# * Pushes to repository.apache.org staging. +# +# The entry point is here, in the do-release-docker.sh script. +# +# 1. https://github.com/apache/spark/tree/master/dev/create-release +# +set -e + +# Set this to build other phoenix repos: e.g. PROJECT=phoenix-connectors +export PROJECT="${PROJECT:-phoenix}" + +SELF="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" +# shellcheck source=SCRIPTDIR/release-util.sh +. "$SELF/release-util.sh" +ORIG_PWD="$(pwd)" + +function usage { + local NAME + NAME="$(basename "${BASH_SOURCE[0]}")" + cat <<EOF +Usage: $NAME [options] + +This script runs the release scripts inside a docker image. Review comment: Maybe put a copy of the generated usage (and a common usage example, too) into README.txt? ########## File path: dev/create-release/vote.tmpl ########## @@ -0,0 +1,31 @@ +Please vote on this Apache ${PROJECT_TEXT} release candidate, +${PROJECT}-${RELEASE_TAG} + +The VOTE will remain open for at least 72 hours. + +[ ] +1 Release this package as Apache ${PROJECT_TEXT} ${RELEASE_VERSION} +[ ] -1 Do not release this package because ... + +The tag to be voted on is ${RELEASE_TAG}: + + https://github.com/apache/${PROJECT}/tree/${RELEASE_TAG} + +The release files, including signatures, digests, as well as CHANGES.md +and RELEASENOTES.md included in this RC can be found at: + + https://dist.apache.org/repos/dist/dev/hbase/${RELEASE_TAG}/ + +Maven artifacts are available in a staging repository at: + + https://repository.apache.org/content/repositories/${staged_repo_id}/ + +Artifacts were signed with the ${GPG_KEY} key which can be found in: + + https://dist.apache.org/repos/dist/release/hbase/KEYS + +To learn more about Apache ${PROJECT_TEXT}, please see + + http://hbase.apache.org/ Review comment: phoenix ########## File path: dev/create-release/vote.tmpl ########## @@ -0,0 +1,31 @@ +Please vote on this Apache ${PROJECT_TEXT} release candidate, +${PROJECT}-${RELEASE_TAG} + +The VOTE will remain open for at least 72 hours. + +[ ] +1 Release this package as Apache ${PROJECT_TEXT} ${RELEASE_VERSION} +[ ] -1 Do not release this package because ... + +The tag to be voted on is ${RELEASE_TAG}: + + https://github.com/apache/${PROJECT}/tree/${RELEASE_TAG} + +The release files, including signatures, digests, as well as CHANGES.md +and RELEASENOTES.md included in this RC can be found at: + + https://dist.apache.org/repos/dist/dev/hbase/${RELEASE_TAG}/ Review comment: dist/dev/phoenix ########## File path: dev/create-release/vote.tmpl ########## @@ -0,0 +1,31 @@ +Please vote on this Apache ${PROJECT_TEXT} release candidate, +${PROJECT}-${RELEASE_TAG} + +The VOTE will remain open for at least 72 hours. + +[ ] +1 Release this package as Apache ${PROJECT_TEXT} ${RELEASE_VERSION} +[ ] -1 Do not release this package because ... + +The tag to be voted on is ${RELEASE_TAG}: + + https://github.com/apache/${PROJECT}/tree/${RELEASE_TAG} + +The release files, including signatures, digests, as well as CHANGES.md +and RELEASENOTES.md included in this RC can be found at: + + https://dist.apache.org/repos/dist/dev/hbase/${RELEASE_TAG}/ + +Maven artifacts are available in a staging repository at: + + https://repository.apache.org/content/repositories/${staged_repo_id}/ + +Artifacts were signed with the ${GPG_KEY} key which can be found in: + + https://dist.apache.org/repos/dist/release/hbase/KEYS Review comment: dist/release/phoenix ########## File path: dev/create-release/vote.tmpl ########## @@ -0,0 +1,31 @@ +Please vote on this Apache ${PROJECT_TEXT} release candidate, +${PROJECT}-${RELEASE_TAG} + +The VOTE will remain open for at least 72 hours. + +[ ] +1 Release this package as Apache ${PROJECT_TEXT} ${RELEASE_VERSION} +[ ] -1 Do not release this package because ... + +The tag to be voted on is ${RELEASE_TAG}: + + https://github.com/apache/${PROJECT}/tree/${RELEASE_TAG} + +The release files, including signatures, digests, as well as CHANGES.md +and RELEASENOTES.md included in this RC can be found at: + + https://dist.apache.org/repos/dist/dev/hbase/${RELEASE_TAG}/ + +Maven artifacts are available in a staging repository at: + + https://repository.apache.org/content/repositories/${staged_repo_id}/ + +Artifacts were signed with the ${GPG_KEY} key which can be found in: + + https://dist.apache.org/repos/dist/release/hbase/KEYS + +To learn more about Apache ${PROJECT_TEXT}, please see + + http://hbase.apache.org/ + +Thanks, +Your HBase Release Manager Review comment: Phoenix ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Consider adopting the create-release scripts and process from HBase > ------------------------------------------------------------------- > > Key: PHOENIX-6178 > URL: https://issues.apache.org/jira/browse/PHOENIX-6178 > Project: Phoenix > Issue Type: Wish > Reporter: Istvan Toth > Assignee: Istvan Toth > Priority: Major > > HBase has moved on to a new release script, which seems easier to use and has > docker support. > Consider adopting it to Phoenix. -- This message was sent by Atlassian Jira (v8.3.4#803005)