[ https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213634#comment-17213634 ]
ASF GitHub Bot commented on PHOENIX-6124: ----------------------------------------- stoty commented on pull request #917: URL: https://github.com/apache/phoenix/pull/917#issuecomment-708176757 It is indeed. Jenkins reports that no builds have happened, even though we can clearly see that they did, and the above report was generated. The same happened for PR 918, and 919. I haven't touched this precommit job config in weeks. If this keeps happening, we'll need to ask for help from INFRA. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Block adding/dropping a column on a parent view for clients <4.15 and for > clients that have phoenix.allow.system.catalog.rollback=true > -------------------------------------------------------------------------------------------------------------------------------------- > > Key: PHOENIX-6124 > URL: https://issues.apache.org/jira/browse/PHOENIX-6124 > Project: Phoenix > Issue Type: Bug > Affects Versions: 5.0.0, 4.15.0 > Reporter: Chinmay Kulkarni > Assignee: Viraj Jasani > Priority: Blocker > Fix For: 5.1.0, 4.16.0 > > Attachments: PHOENIX-6124.master.000.patch > > > For pre-4.15 clients, we have to block adding/dropping a column to a table if > it has child views since we can’t do any checkAndPut distributed locking (see > [this|https://github.com/apache/phoenix/blob/6ecc66738e576a5349605c2f5b20003df03f95de/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L2595-L2616]). > > However, this is only prevented if the parent is a table and not if the > parent is a view. We should extend [the > condition|https://github.com/apache/phoenix/blob/6ecc66738e576a5349605c2f5b20003df03f95de/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L2591] > to also cover views since conflicting mutations on its children can also > lead to inconsistencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)