kadirozde commented on a change in pull request #915:
URL: https://github.com/apache/phoenix/pull/915#discussion_r504924842



##########
File path: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
##########
@@ -1103,13 +1104,21 @@ private RegionScanner rebuildIndices(final 
RegionScanner innerScanner, final Reg
             if (oldCoproc) {
                 return new IndexerRegionScanner(scanner, region, scan, env, 
this);
             } else {
-                return new IndexRebuildRegionScanner(scanner, region, scan, 
env, this);
+                if 
(region.getTableDesc().hasCoprocessor(IndexRegionObserver.class.getCanonicalName()))
 {

Review comment:
       We have not removed Indexer yet. Regarding the PTable comment, this is a 
server side code and in general we do not want to access the syscat on the 
server side for performance reasons mainly. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to