[ https://issues.apache.org/jira/browse/PHOENIX-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17220957#comment-17220957 ]
Hadoop QA commented on PHOENIX-5998: ------------------------------------ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 47s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m 0s{color} | {color:green} No case conflicting files found. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} 4.x Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 0s{color} | {color:green} 4.x passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 51s{color} | {color:green} 4.x passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 16s{color} | {color:green} 4.x passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s{color} | {color:green} 4.x passed {color} | | {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m 46s{color} | {color:blue} phoenix-core in 4.x has 954 extant spotbugs warnings. {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 10s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 52s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 23s{color} | {color:red} phoenix-core: The patch generated 314 new + 1796 unchanged - 219 fixed = 2110 total (was 2015) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} spotbugs {color} | {color:red} 3m 1s{color} | {color:red} phoenix-core generated 1 new + 953 unchanged - 1 fixed = 954 total (was 954) {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red}121m 28s{color} | {color:red} phoenix-core in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 34s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}146m 15s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:phoenix-core | | | Switch statement found in org.apache.phoenix.coprocessor.UngroupedAggregateRegionScanner.descRowKeyOrderUpgrade(List, ImmutableBytesWritable, UngroupedAggregateRegionObserver$MutationList) where default case is missing At UngroupedAggregateRegionScanner.java:ImmutableBytesWritable, UngroupedAggregateRegionObserver$MutationList) where default case is missing At UngroupedAggregateRegionScanner.java:[lines 382-403] | | Failed junit tests | phoenix.end2end.OrphanViewToolIT | | | phoenix.end2end.UpsertSelectIT | | | phoenix.end2end.DeleteIT | | | phoenix.end2end.PhoenixRuntimeIT | | | phoenix.end2end.DropIndexedColsIT | \\ \\ || Subsystem || Report/Notes || | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/106/artifact/patchprocess/Dockerfile | | JIRA Issue | PHOENIX-5998 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/13014143/PHOENIX-5998.4.x.003.patch | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 9217a1c3da0b 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / 135692c | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/106/artifact/patchprocess/diff-checkstyle-phoenix-core.txt | | spotbugs | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/106/artifact/patchprocess/new-spotbugs-phoenix-core.html | | unit | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/106/artifact/patchprocess/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/106/testReport/ | | Max. process+thread count | 7095 (vs. ulimit of 30000) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/106/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. > Paged server side ungrouped aggregate operations > ------------------------------------------------- > > Key: PHOENIX-5998 > URL: https://issues.apache.org/jira/browse/PHOENIX-5998 > Project: Phoenix > Issue Type: Improvement > Reporter: Kadir OZDEMIR > Assignee: Kadir OZDEMIR > Priority: Major > Fix For: 4.x > > Attachments: PHOENIX-5998.4.x.001.patch, PHOENIX-5998.4.x.002.patch, > PHOENIX-5998.4.x.003.patch > > > Phoenix provides the option of performing upsert select and delete query > operations on the client or server side. This is decided by the Phoenix > optimizer based on configuration parameters. For the server side option, the > table operation (upsert select/delete query) is parallelized such that > multiple table regions are scanned and the mutations derived from these scans > can also be executed in parallel on the server side. However, currently there > is no paging capability and the server side operation can take long enough > lead to HBase client timeouts. When this happens, Phoenix can return failure > to its applications and the rest of the parallel scans and mutations on the > server side can still continue since Phoenix has no mechanism in place to > stop these operations before returning failure to applications. This can > create unexpected race conditions between these left-over operations and the > new operations issued by applications. Putting a limit on the number of rows > to be processed within a single RPC call (i.e., the next operation on the > scanner) on the server side using a Phoenix level paging is highly desirable > and a required step to prevent the possible race conditions. This paging > mechanism has been already implemented for index rebuild and verification > operations and proven to be effective to prevent timeouts. This paging can be > implemented for all server side operations including aggregates, upsert > selects, delete queries and so on. -- This message was sent by Atlassian Jira (v8.3.4#803005)