kadirozde commented on pull request #936: URL: https://github.com/apache/phoenix/pull/936#issuecomment-716946162
> @kadirozde The changes are substantial and I will need some heads-down time to review them. If it is urgent, please feel free to rely on other's reviews and don't wait for me. I plan on taking a look in detail within the next couple of days. No, it is not urgent. I was going to start working on PHOENIX-6207 and there is some dependency between them and so I wanted to push this before starting the other. But it is okay and I do not have to wait for this PR to be checked in. Please take your time. Yes, the changes are substantial but mostly mechanic. The core of the change is that instead of scanning the entire table region in the postScannerOpen hook and returning the result of the aggregate operation for the entire table region in one result iteration, this PR just returns a region scanner (i.e., an new scanner called UngroupedAggregateRegionScanner) in the postScannerOpen hook for the UngroupedAggregateRegionObserver coproc, and then applies the aggregate operation on a chunk (i.e, page) of a table region in each result iteration. This means the client needs to do many iterations in order to process a table region and aggregate the results of these pages on the client side. Please note that previously, the client needed to aggregate the results of server side aggregations, one for each table region (not for each table region page). Hope this helps. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
