virajjasani commented on a change in pull request #942:
URL: https://github.com/apache/phoenix/pull/942#discussion_r514894983
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java
##########
@@ -437,8 +472,17 @@ public void run() {
}
// Executes the SQL commands listed in the given operation file from the
sql_files directory
- private void executeQueriesWithCurrentVersion(String operation) throws
Exception {
+ private void executeQueriesWithCurrentVersion(String operation,
+ boolean setMaxLookBackAge) throws Exception {
Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ if (setMaxLookBackAge) {
+ props.put(
+
QueryServices.GLOBAL_INDEX_ROW_AGE_THRESHOLD_TO_DELETE_MS_ATTRIB,
Review comment:
My bad, this is not needed, it came as part of copy from existing test.
Removed it.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
