[
https://issues.apache.org/jira/browse/PHOENIX-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225402#comment-17225402
]
ASF GitHub Bot commented on PHOENIX-6091:
-----------------------------------------
virajjasani commented on a change in pull request #953:
URL: https://github.com/apache/phoenix/pull/953#discussion_r516581750
##########
File path:
phoenix-core/src/test/java/org/apache/phoenix/schema/MetaDataClientTest.java
##########
@@ -83,4 +85,13 @@ public void testHandleCreateTableMutationCodeWithNewCode()
throws SQLException {
}
}
+ @Test
+ public void testMetaDataProtocolVersion() {
+ long serversTimstamp = System.currentTimeMillis();
+ String version = MetaDataProtocol.getVersion(serversTimstamp);
+ assertEquals("4.16.x", version); // We have to update it after every
release
+ assertEquals(String.format("%d.%d.%s", PHOENIX_MAJOR_VERSION,
PHOENIX_MINOR_VERSION, "x"),
Review comment:
I believe this assert might be better fit for all branches and the one
above `assertEquals("4.16.x", version);` might not be needed. Thought?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Calling MetaDataProtocol.getVersion() on a 4.16 timestamp gives version as
> 4.15.x
> ---------------------------------------------------------------------------------
>
> Key: PHOENIX-6091
> URL: https://issues.apache.org/jira/browse/PHOENIX-6091
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.16.0
> Reporter: Chinmay Kulkarni
> Assignee: Richard Antal
> Priority: Minor
> Fix For: 4.16.0
>
> Attachments: PHOENIX-6091.4.x.v1.patch, PHOENIX-6091.4.x.v2.patch
>
>
> This is probably because we haven't added an entry for 4.16 in the
> MetaDataProtocol.TIMESTAMP_VERSION_MAP
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
