[
https://issues.apache.org/jira/browse/PHOENIX-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230338#comment-17230338
]
ASF GitHub Bot commented on PHOENIX-6220:
-----------------------------------------
stoty commented on pull request #963:
URL: https://github.com/apache/phoenix/pull/963#issuecomment-725806207
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 42s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ 4.x-PHOENIX-5923 Compile Tests _ |
| +1 :green_heart: | mvninstall | 10m 54s | 4.x-PHOENIX-5923 passed |
| +1 :green_heart: | compile | 0m 55s | 4.x-PHOENIX-5923 passed |
| +1 :green_heart: | checkstyle | 1m 41s | 4.x-PHOENIX-5923 passed |
| +1 :green_heart: | javadoc | 0m 44s | 4.x-PHOENIX-5923 passed |
| +0 :ok: | spotbugs | 2m 58s | phoenix-core in 4.x-PHOENIX-5923 has
946 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 25s | the patch passed |
| +1 :green_heart: | compile | 0m 56s | the patch passed |
| +1 :green_heart: | javac | 0m 56s | the patch passed |
| -1 :x: | checkstyle | 1m 41s | phoenix-core: The patch generated 45
new + 2812 unchanged - 16 fixed = 2857 total (was 2828) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 42s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 1s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 130m 11s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 38s | The patch does not generate
ASF License warnings. |
| | | 168m 9s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.IndexToolIT |
| | phoenix.end2end.StatsEnabledSplitSystemCatalogIT |
| | phoenix.tx.TransactionIT |
| | phoenix.end2end.ParameterizedIndexUpgradeToolIT |
| | phoenix.end2end.ViewMetadataIT |
| | phoenix.end2end.index.txn.RollbackIT |
| | phoenix.execute.PartialCommitIT |
| | phoenix.rpc.UpdateCacheIT |
| | phoenix.end2end.index.txn.TxWriteFailureIT |
| | phoenix.end2end.TransactionalViewIT |
| | phoenix.tx.FlappingTransactionIT |
| | phoenix.end2end.index.txn.MutableRollbackIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/963 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux a3b14b793693 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x-PHOENIX-5923 / c9c80b2 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/1/testReport/
|
| Max. process+thread count | 7018 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-963/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> CREATE INDEX shouldn't ignore IMMUTABLE_STORAGE_SCHEME and
> COLUMN_ENDCODED_BYTES
> ----------------------------------------------------------------------------------
>
> Key: PHOENIX-6220
> URL: https://issues.apache.org/jira/browse/PHOENIX-6220
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Gokcen Iskender
> Assignee: Gokcen Iskender
> Priority: Major
> Attachments: PHOENIX-6220.4.x.001.patch
>
>
> IMMUTABLE_STORAGE_SCHEME and COLUMN_ENCODED_BYTES that is specified in CREATE
> INDEX needs to be respected. Today, it is ignored and value is just gotten
> from the parent. Parent table can still use ONE_CELL_PER_COLUMN storage
> scheme. If the parent table is using COLUMN_ENCODED_BYTES=0 (none), we
> recommend using COLUMN_ENCODED_BYTES=2 for the index table by default (can be
> overriden) when SINGLE_CELL storage scheme is used. 2-byte column mapping
> enables to define 65535 columns which should be enough.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
