[
https://issues.apache.org/jira/browse/PHOENIX-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231261#comment-17231261
]
ASF GitHub Bot commented on PHOENIX-6140:
-----------------------------------------
stoty commented on pull request #30:
URL: https://github.com/apache/phoenix-connectors/pull/30#issuecomment-726624926
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 55s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
2 new or modified test files. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 8m 30s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 48s | master passed |
| +1 :green_heart: | compile | 2m 46s | master passed |
| +1 :green_heart: | checkstyle | 0m 19s | master passed |
| -1 :x: | javadoc | 0m 14s | phoenix-kafka-base in master failed. |
| -1 :x: | javadoc | 0m 9s | phoenix4-kafka in master failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-kafka in master failed. |
| +0 :ok: | spotbugs | 4m 53s | root in master has 111 extant spotbugs
warnings. |
| +0 :ok: | spotbugs | 1m 15s | phoenix-flume-base in master has 9
extant spotbugs warnings. |
| +0 :ok: | spotbugs | 1m 57s | phoenix-hive-base in master has 47
extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 51s | phoenix-hive-base/phoenix4-hive in
master has 47 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 1m 0s | phoenix-hive-base/phoenix5-hive in
master has 46 extant spotbugs warnings. |
| -1 :x: | spotbugs | 0m 24s | phoenix-kafka-base in master failed. |
| +0 :ok: | spotbugs | 1m 11s | phoenix-pig-base in master has 12
extant spotbugs warnings. |
| +0 :ok: | spotbugs | 1m 33s | phoenix-spark-base in master has 40
extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 46s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 8m 0s | the patch passed |
| +1 :green_heart: | compile | 2m 29s | the patch passed |
| +1 :green_heart: | javac | 2m 29s | root generated 0 new + 0
unchanged - 28 fixed = 0 total (was 28) |
| +1 :green_heart: | checkstyle | 0m 18s | the patch passed |
| -1 :x: | whitespace | 0m 0s | The patch has 10 line(s) that end in
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| +1 :green_heart: | xml | 0m 27s | The patch has no ill-formed XML
file. |
| -1 :x: | yamllint | 0m 0s | The patch generated 12 new + 5 unchanged
- 1 fixed = 17 total (was 6) |
| +1 :green_heart: | javadoc | 0m 10s |
phoenix-connectors-phoenix4-compat in the patch passed. |
| +1 :green_heart: | javadoc | 0m 12s | phoenix4-flume in the patch
passed. |
| +1 :green_heart: | javadoc | 0m 13s | phoenix-pig-base_phoenix4-pig
generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3) |
| -1 :x: | javadoc | 0m 8s | phoenix4-kafka in the patch failed. |
| +1 :green_heart: | javadoc | 0m 15s | phoenix4-spark in the patch
passed. |
| +1 :green_heart: | javadoc | 0m 14s | phoenix-hive-base_phoenix4-hive
generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4) |
| +1 :green_heart: | javadoc | 0m 9s | phoenix4-connectors-assembly in
the patch passed. |
| +1 :green_heart: | javadoc | 0m 10s |
phoenix-connectors-phoenix5-compat in the patch passed. |
| +1 :green_heart: | javadoc | 0m 13s | phoenix5-flume in the patch
passed. |
| +1 :green_heart: | javadoc | 0m 13s | phoenix-pig-base_phoenix5-pig
generated 0 new + 2 unchanged - 1 fixed = 2 total (was 3) |
| -1 :x: | javadoc | 0m 9s | phoenix5-kafka in the patch failed. |
| +1 :green_heart: | javadoc | 0m 14s | phoenix5-spark in the patch
passed. |
| +1 :green_heart: | javadoc | 0m 18s | phoenix-hive-base_phoenix5-hive
generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4) |
| -1 :x: | javadoc | 0m 10s | phoenix5-connectors-assembly in the patch
failed. |
| +1 :green_heart: | javadoc | 0m 53s | root generated 0 new + 20
unchanged - 4 fixed = 20 total (was 24) |
| +1 :green_heart: | javadoc | 0m 17s | phoenix-flume-base in the patch
passed. |
| +1 :green_heart: | javadoc | 0m 25s | phoenix-hive-base generated 0
new + 6 unchanged - 2 fixed = 6 total (was 8) |
| -1 :x: | javadoc | 0m 11s | phoenix-kafka-base in the patch failed. |
| +1 :green_heart: | javadoc | 0m 18s | phoenix-pig-base generated 0
new + 4 unchanged - 2 fixed = 4 total (was 6) |
| +1 :green_heart: | javadoc | 0m 19s | phoenix-spark-base in the patch
passed. |
| +1 :green_heart: | spotbugs | 0m 37s |
phoenix-connectors-phoenix4-compat in the patch passed. |
| +1 :green_heart: | spotbugs | 1m 2s |
phoenix-hive-base/phoenix4-hive generated 0 new + 46 unchanged - 1 fixed = 46
total (was 47) |
| +1 :green_heart: | spotbugs | 0m 40s |
phoenix-connectors-phoenix5-compat in the patch passed. |
| +1 :green_heart: | spotbugs | 1m 10s |
phoenix-hive-base/phoenix5-hive generated 0 new + 45 unchanged - 1 fixed = 45
total (was 46) |
| -1 :x: | spotbugs | 4m 55s | root generated 6 new + 110 unchanged - 1
fixed = 116 total (was 111) |
| +1 :green_heart: | spotbugs | 1m 22s | phoenix-flume-base in the
patch passed. |
| +1 :green_heart: | spotbugs | 1m 41s | phoenix-hive-base generated 0
new + 46 unchanged - 1 fixed = 46 total (was 47) |
| -1 :x: | spotbugs | 0m 26s | phoenix-kafka-base in the patch failed.
|
| -1 :x: | spotbugs | 1m 20s | phoenix-pig-base generated 6 new + 12
unchanged - 0 fixed = 18 total (was 12) |
| +1 :green_heart: | spotbugs | 1m 39s | phoenix-spark-base in the
patch passed. |
||| _ Other Tests _ |
| -1 :x: | unit | 66m 9s | root in the patch failed. |
| -1 :x: | asflicense | 2m 19s | The patch generated 14 ASF License
warnings. |
| | | 151m 24s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:root |
| | Possible null pointer dereference in
org.apache.phoenix.pig.PhoenixHBaseLoader.initializePhoenixPigConfiguration(String,
Configuration) due to return value of called method Dereferenced at
PhoenixHBaseLoader.java:org.apache.phoenix.pig.PhoenixHBaseLoader.initializePhoenixPigConfiguration(String,
Configuration) due to return value of called method Dereferenced at
PhoenixHBaseLoader.java:[line 147] |
| | Possible null pointer dereference in
org.apache.phoenix.pig.PhoenixHBaseStorage.setStoreLocation(String, Job) due to
return value of called method Dereferenced at
PhoenixHBaseStorage.java:org.apache.phoenix.pig.PhoenixHBaseStorage.setStoreLocation(String,
Job) due to return value of called method Dereferenced at
PhoenixHBaseStorage.java:[line 155] |
| | Possible null pointer dereference in
org.apache.phoenix.pig.util.PhoenixPigSchemaUtil.getResourceSchema(Configuration,
PhoenixPigSchemaUtil$Dependencies) due to return value of called method
Dereferenced at
PhoenixPigSchemaUtil.java:org.apache.phoenix.pig.util.PhoenixPigSchemaUtil.getResourceSchema(Configuration,
PhoenixPigSchemaUtil$Dependencies) due to return value of called method
Dereferenced at PhoenixPigSchemaUtil.java:[line 68] |
| | selectStatement must be non-null but is marked as nullable At
QuerySchemaParserFunction.java:is marked as nullable At
QuerySchemaParserFunction.java:[lines 56-88] |
| | column must be non-null but is marked as nullable At
QuerySchemaParserFunction.java:is marked as nullable At
QuerySchemaParserFunction.java:[line 71] |
| | columnProjector must be non-null but is marked as nullable At
SqlQueryToColumnInfoFunction.java:is marked as nullable At
SqlQueryToColumnInfoFunction.java:[line 62] |
| FindBugs | module:phoenix-pig-base |
| | Possible null pointer dereference in
org.apache.phoenix.pig.PhoenixHBaseLoader.initializePhoenixPigConfiguration(String,
Configuration) due to return value of called method Dereferenced at
PhoenixHBaseLoader.java:org.apache.phoenix.pig.PhoenixHBaseLoader.initializePhoenixPigConfiguration(String,
Configuration) due to return value of called method Dereferenced at
PhoenixHBaseLoader.java:[line 147] |
| | Possible null pointer dereference in
org.apache.phoenix.pig.PhoenixHBaseStorage.setStoreLocation(String, Job) due to
return value of called method Dereferenced at
PhoenixHBaseStorage.java:org.apache.phoenix.pig.PhoenixHBaseStorage.setStoreLocation(String,
Job) due to return value of called method Dereferenced at
PhoenixHBaseStorage.java:[line 155] |
| | Possible null pointer dereference in
org.apache.phoenix.pig.util.PhoenixPigSchemaUtil.getResourceSchema(Configuration,
PhoenixPigSchemaUtil$Dependencies) due to return value of called method
Dereferenced at
PhoenixPigSchemaUtil.java:org.apache.phoenix.pig.util.PhoenixPigSchemaUtil.getResourceSchema(Configuration,
PhoenixPigSchemaUtil$Dependencies) due to return value of called method
Dereferenced at PhoenixPigSchemaUtil.java:[line 68] |
| | selectStatement must be non-null but is marked as nullable At
QuerySchemaParserFunction.java:is marked as nullable At
QuerySchemaParserFunction.java:[lines 56-88] |
| | column must be non-null but is marked as nullable At
QuerySchemaParserFunction.java:is marked as nullable At
QuerySchemaParserFunction.java:[line 71] |
| | columnProjector must be non-null but is marked as nullable At
SqlQueryToColumnInfoFunction.java:is marked as nullable At
SqlQueryToColumnInfoFunction.java:[line 62] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/30 |
| Optional Tests | dupname asflicense yamllint javac javadoc unit xml
compile spotbugs hbaseanti checkstyle |
| uname | Linux 520388dc046f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / b5f62a5 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/branch-javadoc-phoenix-kafka-base.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/branch-javadoc-phoenix-kafka-base_phoenix4-kafka.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/branch-javadoc-phoenix-kafka-base_phoenix5-kafka.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/branch-spotbugs-phoenix-kafka-base.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/whitespace-eol.txt
|
| yamllint |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/diff-patch-yamllint.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/patch-javadoc-phoenix-kafka-base_phoenix4-kafka.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/patch-javadoc-phoenix-kafka-base_phoenix5-kafka.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/patch-javadoc-phoenix5-connectors-assembly.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/patch-javadoc-phoenix-kafka-base.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/new-spotbugs-root.html
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/patch-spotbugs-phoenix-kafka-base.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/new-spotbugs-phoenix-pig-base.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/testReport/
|
| asflicense |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/artifact/yetus-general-check/output/patch-asflicense-problems.txt
|
| Max. process+thread count | 2934 (vs. ulimit of 30000) |
| modules | C: phoenix-connectors-phoenix4-compat
phoenix-flume-base/phoenix4-flume phoenix-pig-base/phoenix4-pig
phoenix-kafka-base/phoenix4-kafka phoenix-spark-base/phoenix4-spark
phoenix-hive-base/phoenix4-hive phoenix4-connectors-assembly
phoenix-connectors-phoenix5-compat phoenix-flume-base/phoenix5-flume
phoenix-pig-base/phoenix5-pig phoenix-kafka-base/phoenix5-kafka
phoenix-spark-base/phoenix5-spark phoenix-hive-base/phoenix5-hive
phoenix5-connectors-assembly . phoenix-flume-base phoenix-hive-base
phoenix-kafka-base phoenix-pig-base phoenix-spark-base U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-30/8/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.4 yamllint=1.20.0 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Update connectors maven configuration
> -------------------------------------
>
> Key: PHOENIX-6140
> URL: https://issues.apache.org/jira/browse/PHOENIX-6140
> Project: Phoenix
> Issue Type: Improvement
> Components: connectors
> Affects Versions: connectors-6.0.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> The connectors maven setup is using an old apache parent, and old plugin
> versions, and the config is not the cleanest.
> Update the parent/plugins versions and do a pass of cleaning up plugin config.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
