stoty commented on pull request #964: URL: https://github.com/apache/phoenix/pull/964#issuecomment-726754559
Thanks @virajjasani. The precommit tests are irrelevant for this patch, as those are run with 2.1.9, which is the almost certainly the final 2.1 release, and hasn't been changed. I consider HBase patch release upgrades to be generally low risk, unless there is a breaking API change, which usually manifests at compile time. ATM precommit runs the full test suite, it only skips modules if there are no changes in the module, nor in its dependencies. Flakey tests are a huge problem, and we really should take them more seriously as a project. I haven't had a chance to look at recent flakeys, and I cannot promise that I will in near future, but I REALLY would like to have the tests stabilized by the time we release 5.1 . ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
