gjacoby126 commented on pull request #935: URL: https://github.com/apache/phoenix/pull/935#issuecomment-728212707
@shahrs87 - Of the three findbugs errors, the first is unclear to me, the second is complaining about a potential resource leak in the boostrap code (valid complaint) and the third is complaining about a potential SQL injection vulnerability (incorrect, but understandable). I've changed it to use a PreparedStatement in a try-with-resources executing a constant string. Went through the checkstyle findings. The line lengths checks looks misconfigured (it's 80 but should be 100, and we routinely let things a little longer than 100 slide). I did go through and fix a bunch of whitespace complaints around if and for blocks, plus marking some params final, to clear out some of the noise. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
