[
https://issues.apache.org/jira/browse/PHOENIX-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238104#comment-17238104
]
Istvan Toth commented on PHOENIX-6010:
--------------------------------------
It was not applied, because it's not strictly necessary for 4.x, as every
component is compatible with Guava 13 on that branch.
However, I agree that we should consider doing the same on 4.x, to simplify
back- and forward porting changes between the branches.
> Create phoenix-thirdparty, and consume guava through it
> -------------------------------------------------------
>
> Key: PHOENIX-6010
> URL: https://issues.apache.org/jira/browse/PHOENIX-6010
> Project: Phoenix
> Issue Type: Improvement
> Components: core, omid, tephra
> Affects Versions: 5.1.0, 4.16.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Fix For: 5.1.0
>
> Attachments: PHOENIX-6010.master.10.patch,
> PHOENIX-6010.master.v1.patch, PHOENIX-6010.master.v2.patch,
> PHOENIX-6010.master.v3.patch, PHOENIX-6010.master.v4.patch,
> PHOENIX-6010.master.v5.patch, PHOENIX-6010.master.v6.patch,
> PHOENIX-6010.master.v7.patch, PHOENIX-6010.master.v8.patch,
> PHOENIX-6010.master.v9.patch
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> We have long-standing and well-documented problems with Guava, just like the
> rest of the Hadoop components.
> Adopt the solution used by HBase:
> * create phoenix-thirdparty repo
> * create a pre-shaded phoenix-shaded-guava artifact in it
> * Use the pre-shaded Guava in every phoenix component
> The advantages are well-known, but to name a few:
> * Phoenix will work with Hadoop 3.1.3+
> * One less CVE in our direct dependencies
> * No more conflict with our consumer's Guava versions
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
