[
https://issues.apache.org/jira/browse/PHOENIX-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239720#comment-17239720
]
ASF GitHub Bot commented on PHOENIX-6213:
-----------------------------------------
virajjasani commented on a change in pull request #978:
URL: https://github.com/apache/phoenix/pull/978#discussion_r531606951
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/DeleteIT.java
##########
@@ -943,6 +961,163 @@ public void testDeleteFilterWithMultipleIndexes() throws
Exception {
}
}
}
-}
+ /*
+ Tests whether we have cell tags in delete marker for
+ ClientSelectDeleteMutationPlan.
+ */
+ @Test
+ public void testDeleteClientDeleteMutationPlan() throws Exception {
+ String tableName = generateUniqueName();
+ String indexName = generateUniqueName();
+ String tagValue = "customer-delete";
+ String delete = "DELETE FROM " + tableName + " WHERE v1 = 'foo'";
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ // Add tag "customer-delete" to delete marker.
+ props.setProperty(ConnectionQueryServices.SOURCE_OPERATION_ATTRIB,
tagValue);
+
+ createAndUpsertTable(tableName, indexName, props);
+ // Make sure that the plan creates is of ClientSelectDeleteMutationPlan
+ verifyDeletePlan(delete,
DeleteCompiler.ClientSelectDeleteMutationPlan.class, props);
+ executeDelete(delete, props, 1);
+ String startRowKeyForBaseTable = "1";
+ String startRowKeyForIndexTable = "foo";
+ // Make sure that Delete Marker has cell tag for base table
+ // and has no cell tag for index table.
+ checkTagPresentInDeleteMarker(tableName, startRowKeyForBaseTable,
true, tagValue);
+ checkTagPresentInDeleteMarker(indexName, startRowKeyForIndexTable,
false, null);
+ }
+
+ /*
+ Tests whether we have cell tags in delete marker for
+ ServerSelectDeleteMutationPlan.
+ */
+ @Test
+ public void testDeleteServerDeleteMutationPlan() throws Exception {
+ String tableName = generateUniqueName();
+ String indexName = generateUniqueName();
+ String tagValue = "customer-delete";
+ String delete = "DELETE FROM " + tableName;
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ props.setProperty(ConnectionQueryServices.SOURCE_OPERATION_ATTRIB,
tagValue);
+
+ createAndUpsertTable(tableName, indexName, props);
+ // Make sure that the plan creates is of ServerSelectDeleteMutationPlan
+ verifyDeletePlan(delete,
DeleteCompiler.ServerSelectDeleteMutationPlan.class, props);
+ executeDelete(delete, props, 2);
+
+ String startRowKeyForBaseTable = "1";
+ String startRowKeyForIndexTable = "foo";
+ // Make sure that Delete Marker has cell tag for base table
+ // and has no cell tag for index table.
+ checkTagPresentInDeleteMarker(tableName, startRowKeyForBaseTable,
true, tagValue);
+ checkTagPresentInDeleteMarker(indexName, startRowKeyForIndexTable,
false, null);
+ }
+
+ /*
+ Tests whether we have cell tags in delete marker for
+ MultiRowDeleteMutationPlan.
+ */
+ @Test
+ public void testDeleteMultiRowDeleteMutationPlan() throws Exception {
+ String tableName = generateUniqueName();
+ String tagValue = "customer-delete";
+ String delete = "DELETE FROM " + tableName + " WHERE k = 1";
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ props.setProperty(ConnectionQueryServices.SOURCE_OPERATION_ATTRIB,
tagValue);
+ // Don't create index table. We will use MultiRowDeleteMutationPlan
+ // if there is no index present for a table.
+ createAndUpsertTable(tableName, null, props);
+ // Make sure that the plan creates is of MultiRowDeleteMutationPlan
+ verifyDeletePlan(delete,
DeleteCompiler.MultiRowDeleteMutationPlan.class, props);
+ executeDelete(delete, props, 1);
+ String startRowKeyForBaseTable = "1";
+ // Make sure that Delete Marker has cell tag for base table.
+ // We haven't created index table for this test case.
+ checkTagPresentInDeleteMarker(tableName, startRowKeyForBaseTable,
true, tagValue);
+ }
+
+ /*
+ Verify whether plan that we create for delete statement is of planClass
+ */
+ private void verifyDeletePlan(String delete, Class planClass, Properties
props)
Review comment:
nit: `Class<? extends MutationPlan> planClass` ?
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/DeleteIT.java
##########
@@ -943,6 +961,163 @@ public void testDeleteFilterWithMultipleIndexes() throws
Exception {
}
}
}
-}
+ /*
+ Tests whether we have cell tags in delete marker for
+ ClientSelectDeleteMutationPlan.
+ */
+ @Test
+ public void testDeleteClientDeleteMutationPlan() throws Exception {
+ String tableName = generateUniqueName();
+ String indexName = generateUniqueName();
+ String tagValue = "customer-delete";
+ String delete = "DELETE FROM " + tableName + " WHERE v1 = 'foo'";
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ // Add tag "customer-delete" to delete marker.
+ props.setProperty(ConnectionQueryServices.SOURCE_OPERATION_ATTRIB,
tagValue);
+
+ createAndUpsertTable(tableName, indexName, props);
+ // Make sure that the plan creates is of ClientSelectDeleteMutationPlan
+ verifyDeletePlan(delete,
DeleteCompiler.ClientSelectDeleteMutationPlan.class, props);
+ executeDelete(delete, props, 1);
+ String startRowKeyForBaseTable = "1";
+ String startRowKeyForIndexTable = "foo";
+ // Make sure that Delete Marker has cell tag for base table
+ // and has no cell tag for index table.
+ checkTagPresentInDeleteMarker(tableName, startRowKeyForBaseTable,
true, tagValue);
+ checkTagPresentInDeleteMarker(indexName, startRowKeyForIndexTable,
false, null);
+ }
+
+ /*
+ Tests whether we have cell tags in delete marker for
+ ServerSelectDeleteMutationPlan.
+ */
+ @Test
+ public void testDeleteServerDeleteMutationPlan() throws Exception {
+ String tableName = generateUniqueName();
+ String indexName = generateUniqueName();
+ String tagValue = "customer-delete";
+ String delete = "DELETE FROM " + tableName;
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ props.setProperty(ConnectionQueryServices.SOURCE_OPERATION_ATTRIB,
tagValue);
+
+ createAndUpsertTable(tableName, indexName, props);
+ // Make sure that the plan creates is of ServerSelectDeleteMutationPlan
+ verifyDeletePlan(delete,
DeleteCompiler.ServerSelectDeleteMutationPlan.class, props);
+ executeDelete(delete, props, 2);
+
+ String startRowKeyForBaseTable = "1";
+ String startRowKeyForIndexTable = "foo";
+ // Make sure that Delete Marker has cell tag for base table
+ // and has no cell tag for index table.
+ checkTagPresentInDeleteMarker(tableName, startRowKeyForBaseTable,
true, tagValue);
+ checkTagPresentInDeleteMarker(indexName, startRowKeyForIndexTable,
false, null);
+ }
+
+ /*
+ Tests whether we have cell tags in delete marker for
+ MultiRowDeleteMutationPlan.
+ */
+ @Test
+ public void testDeleteMultiRowDeleteMutationPlan() throws Exception {
+ String tableName = generateUniqueName();
+ String tagValue = "customer-delete";
+ String delete = "DELETE FROM " + tableName + " WHERE k = 1";
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ props.setProperty(ConnectionQueryServices.SOURCE_OPERATION_ATTRIB,
tagValue);
+ // Don't create index table. We will use MultiRowDeleteMutationPlan
+ // if there is no index present for a table.
+ createAndUpsertTable(tableName, null, props);
+ // Make sure that the plan creates is of MultiRowDeleteMutationPlan
+ verifyDeletePlan(delete,
DeleteCompiler.MultiRowDeleteMutationPlan.class, props);
+ executeDelete(delete, props, 1);
+ String startRowKeyForBaseTable = "1";
+ // Make sure that Delete Marker has cell tag for base table.
+ // We haven't created index table for this test case.
+ checkTagPresentInDeleteMarker(tableName, startRowKeyForBaseTable,
true, tagValue);
+ }
+
+ /*
+ Verify whether plan that we create for delete statement is of planClass
+ */
+ private void verifyDeletePlan(String delete, Class planClass, Properties
props)
+ throws SQLException {
+ try(Connection conn = DriverManager.getConnection(getUrl(), props)) {
+ conn.setAutoCommit(true);
+ PhoenixStatement stmt =
conn.createStatement().unwrap(PhoenixStatement.class);
+ SQLParser parser = new SQLParser(delete);
+ DeleteStatement deleteStmt = (DeleteStatement)
parser.parseStatement();
+ DeleteCompiler compiler = new DeleteCompiler(stmt, null);
+ MutationPlan plan = compiler.compile(deleteStmt);
+ assertEquals(plan.getClass(), planClass);
+ }
+ }
+ private void createAndUpsertTable(String tableName, String indexName,
Properties props)
+ throws SQLException {
+ String ddl = "CREATE TABLE " + tableName +
+ " (k INTEGER NOT NULL PRIMARY KEY, v1 VARCHAR, v2 VARCHAR)";
+ try(Connection conn = DriverManager.getConnection(getUrl(), props)) {
+ conn.setAutoCommit(true);
+ try (Statement statement = conn.createStatement()) {
+ statement.execute(ddl);
+ if (indexName != null) {
+ String indexDdl1 = "CREATE INDEX " + indexName + " ON " +
tableName + "(v1,v2)";
+ statement.execute(indexDdl1);
+ }
+ }
+ conn.createStatement().execute(
+ "upsert into " + tableName + " values (1, 'foo', 'foo1')");
+ conn.createStatement().execute(
+ "upsert into " + tableName + " values (2, 'bar', 'bar1')");
+ conn.commit();
+ }
+ }
+
+ private void executeDelete(String delete, Properties props, int
deleteRowCount)
+ throws SQLException {
+ try(Connection conn = DriverManager.getConnection(getUrl(), props)) {
+ conn.setAutoCommit(true);
+ try (Statement statement = conn.createStatement()) {
+ int rs = statement.executeUpdate(delete);
+ assertEquals( deleteRowCount, rs);
+ }
+ }
+ }
+ /*
+ Verify whether we have tags present for base table and not present for
+ index tables.
+ */
+ private void checkTagPresentInDeleteMarker(String tableName, String
startRowKey,
+ boolean tagPresent, String tagValue) throws IOException {
+ List<Cell> values = new ArrayList<>();
+ TableName table = TableName.valueOf(tableName);
+ // Scan table with specified startRowKey
+ for (HRegion region :
getUtility().getHBaseCluster().getRegions(table)) {
+ values.clear();
+ Scan scan = new Scan();
+ // Make sure to set rawScan to true so that we will get Delete
Markers.
+ scan.setRaw(true);
+ scan.withStartRow(Bytes.toBytes(startRowKey));
+ RegionScanner scanner = region.getScanner(scan);
+ scanner.next(values);
+ if (!values.isEmpty()) {
+ break;
+ }
+ }
+ assertTrue("Values shouldn't be empty", !values.isEmpty());
Review comment:
nit: simplify to `assertFalse("Values shouldn't be empty",
values.isEmpty());` ?
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/DeleteIT.java
##########
@@ -943,6 +961,163 @@ public void testDeleteFilterWithMultipleIndexes() throws
Exception {
}
}
}
-}
+ /*
+ Tests whether we have cell tags in delete marker for
+ ClientSelectDeleteMutationPlan.
+ */
+ @Test
+ public void testDeleteClientDeleteMutationPlan() throws Exception {
+ String tableName = generateUniqueName();
+ String indexName = generateUniqueName();
+ String tagValue = "customer-delete";
+ String delete = "DELETE FROM " + tableName + " WHERE v1 = 'foo'";
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ // Add tag "customer-delete" to delete marker.
+ props.setProperty(ConnectionQueryServices.SOURCE_OPERATION_ATTRIB,
tagValue);
+
+ createAndUpsertTable(tableName, indexName, props);
+ // Make sure that the plan creates is of ClientSelectDeleteMutationPlan
+ verifyDeletePlan(delete,
DeleteCompiler.ClientSelectDeleteMutationPlan.class, props);
+ executeDelete(delete, props, 1);
+ String startRowKeyForBaseTable = "1";
+ String startRowKeyForIndexTable = "foo";
+ // Make sure that Delete Marker has cell tag for base table
+ // and has no cell tag for index table.
+ checkTagPresentInDeleteMarker(tableName, startRowKeyForBaseTable,
true, tagValue);
+ checkTagPresentInDeleteMarker(indexName, startRowKeyForIndexTable,
false, null);
+ }
+
+ /*
+ Tests whether we have cell tags in delete marker for
+ ServerSelectDeleteMutationPlan.
+ */
+ @Test
+ public void testDeleteServerDeleteMutationPlan() throws Exception {
+ String tableName = generateUniqueName();
+ String indexName = generateUniqueName();
+ String tagValue = "customer-delete";
+ String delete = "DELETE FROM " + tableName;
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ props.setProperty(ConnectionQueryServices.SOURCE_OPERATION_ATTRIB,
tagValue);
+
+ createAndUpsertTable(tableName, indexName, props);
+ // Make sure that the plan creates is of ServerSelectDeleteMutationPlan
+ verifyDeletePlan(delete,
DeleteCompiler.ServerSelectDeleteMutationPlan.class, props);
+ executeDelete(delete, props, 2);
+
+ String startRowKeyForBaseTable = "1";
+ String startRowKeyForIndexTable = "foo";
+ // Make sure that Delete Marker has cell tag for base table
+ // and has no cell tag for index table.
+ checkTagPresentInDeleteMarker(tableName, startRowKeyForBaseTable,
true, tagValue);
+ checkTagPresentInDeleteMarker(indexName, startRowKeyForIndexTable,
false, null);
+ }
+
+ /*
+ Tests whether we have cell tags in delete marker for
+ MultiRowDeleteMutationPlan.
+ */
+ @Test
+ public void testDeleteMultiRowDeleteMutationPlan() throws Exception {
+ String tableName = generateUniqueName();
+ String tagValue = "customer-delete";
+ String delete = "DELETE FROM " + tableName + " WHERE k = 1";
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ props.setProperty(ConnectionQueryServices.SOURCE_OPERATION_ATTRIB,
tagValue);
+ // Don't create index table. We will use MultiRowDeleteMutationPlan
+ // if there is no index present for a table.
+ createAndUpsertTable(tableName, null, props);
+ // Make sure that the plan creates is of MultiRowDeleteMutationPlan
+ verifyDeletePlan(delete,
DeleteCompiler.MultiRowDeleteMutationPlan.class, props);
+ executeDelete(delete, props, 1);
+ String startRowKeyForBaseTable = "1";
+ // Make sure that Delete Marker has cell tag for base table.
+ // We haven't created index table for this test case.
+ checkTagPresentInDeleteMarker(tableName, startRowKeyForBaseTable,
true, tagValue);
+ }
+
+ /*
+ Verify whether plan that we create for delete statement is of planClass
+ */
+ private void verifyDeletePlan(String delete, Class planClass, Properties
props)
+ throws SQLException {
+ try(Connection conn = DriverManager.getConnection(getUrl(), props)) {
+ conn.setAutoCommit(true);
+ PhoenixStatement stmt =
conn.createStatement().unwrap(PhoenixStatement.class);
+ SQLParser parser = new SQLParser(delete);
+ DeleteStatement deleteStmt = (DeleteStatement)
parser.parseStatement();
+ DeleteCompiler compiler = new DeleteCompiler(stmt, null);
+ MutationPlan plan = compiler.compile(deleteStmt);
+ assertEquals(plan.getClass(), planClass);
+ }
+ }
+ private void createAndUpsertTable(String tableName, String indexName,
Properties props)
+ throws SQLException {
+ String ddl = "CREATE TABLE " + tableName +
+ " (k INTEGER NOT NULL PRIMARY KEY, v1 VARCHAR, v2 VARCHAR)";
+ try(Connection conn = DriverManager.getConnection(getUrl(), props)) {
+ conn.setAutoCommit(true);
+ try (Statement statement = conn.createStatement()) {
+ statement.execute(ddl);
+ if (indexName != null) {
+ String indexDdl1 = "CREATE INDEX " + indexName + " ON " +
tableName + "(v1,v2)";
+ statement.execute(indexDdl1);
+ }
+ }
+ conn.createStatement().execute(
+ "upsert into " + tableName + " values (1, 'foo', 'foo1')");
+ conn.createStatement().execute(
+ "upsert into " + tableName + " values (2, 'bar', 'bar1')");
Review comment:
nit: both these statements can be included with above `try (Statement
statement = conn.createStatement())`
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/DeleteIT.java
##########
@@ -943,6 +961,163 @@ public void testDeleteFilterWithMultipleIndexes() throws
Exception {
}
}
}
-}
+ /*
+ Tests whether we have cell tags in delete marker for
+ ClientSelectDeleteMutationPlan.
+ */
+ @Test
+ public void testDeleteClientDeleteMutationPlan() throws Exception {
+ String tableName = generateUniqueName();
+ String indexName = generateUniqueName();
+ String tagValue = "customer-delete";
+ String delete = "DELETE FROM " + tableName + " WHERE v1 = 'foo'";
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ // Add tag "customer-delete" to delete marker.
+ props.setProperty(ConnectionQueryServices.SOURCE_OPERATION_ATTRIB,
tagValue);
+
+ createAndUpsertTable(tableName, indexName, props);
+ // Make sure that the plan creates is of ClientSelectDeleteMutationPlan
+ verifyDeletePlan(delete,
DeleteCompiler.ClientSelectDeleteMutationPlan.class, props);
+ executeDelete(delete, props, 1);
+ String startRowKeyForBaseTable = "1";
+ String startRowKeyForIndexTable = "foo";
+ // Make sure that Delete Marker has cell tag for base table
+ // and has no cell tag for index table.
+ checkTagPresentInDeleteMarker(tableName, startRowKeyForBaseTable,
true, tagValue);
+ checkTagPresentInDeleteMarker(indexName, startRowKeyForIndexTable,
false, null);
+ }
+
+ /*
+ Tests whether we have cell tags in delete marker for
+ ServerSelectDeleteMutationPlan.
+ */
+ @Test
+ public void testDeleteServerDeleteMutationPlan() throws Exception {
+ String tableName = generateUniqueName();
+ String indexName = generateUniqueName();
+ String tagValue = "customer-delete";
+ String delete = "DELETE FROM " + tableName;
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ props.setProperty(ConnectionQueryServices.SOURCE_OPERATION_ATTRIB,
tagValue);
+
+ createAndUpsertTable(tableName, indexName, props);
+ // Make sure that the plan creates is of ServerSelectDeleteMutationPlan
+ verifyDeletePlan(delete,
DeleteCompiler.ServerSelectDeleteMutationPlan.class, props);
Review comment:
`ServerSelectDeleteMutationPlan` is because DELETE query has no WHERE
clause and we have index on base table which will be part of queryPlan?
```
boolean runOnServer = isAutoCommit && !hasPreOrPostProcessing &&
!table.isTransactional() && !hasClientSideIndexes && allowServerMutations;
runOnServer &= queryPlans.get(0).getTableRef().getTable().getType()
!= PTableType.INDEX;
```
Is this the correct reference?
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/DeleteIT.java
##########
@@ -943,6 +961,163 @@ public void testDeleteFilterWithMultipleIndexes() throws
Exception {
}
}
}
-}
+ /*
+ Tests whether we have cell tags in delete marker for
+ ClientSelectDeleteMutationPlan.
+ */
+ @Test
+ public void testDeleteClientDeleteMutationPlan() throws Exception {
+ String tableName = generateUniqueName();
+ String indexName = generateUniqueName();
+ String tagValue = "customer-delete";
+ String delete = "DELETE FROM " + tableName + " WHERE v1 = 'foo'";
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ // Add tag "customer-delete" to delete marker.
+ props.setProperty(ConnectionQueryServices.SOURCE_OPERATION_ATTRIB,
tagValue);
+
+ createAndUpsertTable(tableName, indexName, props);
+ // Make sure that the plan creates is of ClientSelectDeleteMutationPlan
+ verifyDeletePlan(delete,
DeleteCompiler.ClientSelectDeleteMutationPlan.class, props);
+ executeDelete(delete, props, 1);
+ String startRowKeyForBaseTable = "1";
+ String startRowKeyForIndexTable = "foo";
+ // Make sure that Delete Marker has cell tag for base table
+ // and has no cell tag for index table.
+ checkTagPresentInDeleteMarker(tableName, startRowKeyForBaseTable,
true, tagValue);
+ checkTagPresentInDeleteMarker(indexName, startRowKeyForIndexTable,
false, null);
+ }
+
+ /*
+ Tests whether we have cell tags in delete marker for
+ ServerSelectDeleteMutationPlan.
+ */
+ @Test
+ public void testDeleteServerDeleteMutationPlan() throws Exception {
+ String tableName = generateUniqueName();
+ String indexName = generateUniqueName();
+ String tagValue = "customer-delete";
+ String delete = "DELETE FROM " + tableName;
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ props.setProperty(ConnectionQueryServices.SOURCE_OPERATION_ATTRIB,
tagValue);
+
+ createAndUpsertTable(tableName, indexName, props);
+ // Make sure that the plan creates is of ServerSelectDeleteMutationPlan
+ verifyDeletePlan(delete,
DeleteCompiler.ServerSelectDeleteMutationPlan.class, props);
+ executeDelete(delete, props, 2);
+
+ String startRowKeyForBaseTable = "1";
+ String startRowKeyForIndexTable = "foo";
+ // Make sure that Delete Marker has cell tag for base table
+ // and has no cell tag for index table.
+ checkTagPresentInDeleteMarker(tableName, startRowKeyForBaseTable,
true, tagValue);
+ checkTagPresentInDeleteMarker(indexName, startRowKeyForIndexTable,
false, null);
+ }
+
+ /*
+ Tests whether we have cell tags in delete marker for
+ MultiRowDeleteMutationPlan.
+ */
+ @Test
+ public void testDeleteMultiRowDeleteMutationPlan() throws Exception {
+ String tableName = generateUniqueName();
+ String tagValue = "customer-delete";
+ String delete = "DELETE FROM " + tableName + " WHERE k = 1";
+ Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
+ props.setProperty(ConnectionQueryServices.SOURCE_OPERATION_ATTRIB,
tagValue);
+ // Don't create index table. We will use MultiRowDeleteMutationPlan
+ // if there is no index present for a table.
+ createAndUpsertTable(tableName, null, props);
+ // Make sure that the plan creates is of MultiRowDeleteMutationPlan
+ verifyDeletePlan(delete,
DeleteCompiler.MultiRowDeleteMutationPlan.class, props);
+ executeDelete(delete, props, 1);
+ String startRowKeyForBaseTable = "1";
+ // Make sure that Delete Marker has cell tag for base table.
+ // We haven't created index table for this test case.
+ checkTagPresentInDeleteMarker(tableName, startRowKeyForBaseTable,
true, tagValue);
+ }
+
+ /*
+ Verify whether plan that we create for delete statement is of planClass
+ */
+ private void verifyDeletePlan(String delete, Class planClass, Properties
props)
+ throws SQLException {
+ try(Connection conn = DriverManager.getConnection(getUrl(), props)) {
+ conn.setAutoCommit(true);
+ PhoenixStatement stmt =
conn.createStatement().unwrap(PhoenixStatement.class);
+ SQLParser parser = new SQLParser(delete);
+ DeleteStatement deleteStmt = (DeleteStatement)
parser.parseStatement();
+ DeleteCompiler compiler = new DeleteCompiler(stmt, null);
+ MutationPlan plan = compiler.compile(deleteStmt);
+ assertEquals(plan.getClass(), planClass);
+ }
+ }
+ private void createAndUpsertTable(String tableName, String indexName,
Properties props)
+ throws SQLException {
+ String ddl = "CREATE TABLE " + tableName +
+ " (k INTEGER NOT NULL PRIMARY KEY, v1 VARCHAR, v2 VARCHAR)";
+ try(Connection conn = DriverManager.getConnection(getUrl(), props)) {
+ conn.setAutoCommit(true);
+ try (Statement statement = conn.createStatement()) {
+ statement.execute(ddl);
+ if (indexName != null) {
+ String indexDdl1 = "CREATE INDEX " + indexName + " ON " +
tableName + "(v1,v2)";
+ statement.execute(indexDdl1);
+ }
+ }
+ conn.createStatement().execute(
+ "upsert into " + tableName + " values (1, 'foo', 'foo1')");
+ conn.createStatement().execute(
+ "upsert into " + tableName + " values (2, 'bar', 'bar1')");
+ conn.commit();
+ }
+ }
+
+ private void executeDelete(String delete, Properties props, int
deleteRowCount)
+ throws SQLException {
+ try(Connection conn = DriverManager.getConnection(getUrl(), props)) {
+ conn.setAutoCommit(true);
+ try (Statement statement = conn.createStatement()) {
+ int rs = statement.executeUpdate(delete);
+ assertEquals( deleteRowCount, rs);
+ }
+ }
+ }
+ /*
+ Verify whether we have tags present for base table and not present for
+ index tables.
+ */
+ private void checkTagPresentInDeleteMarker(String tableName, String
startRowKey,
+ boolean tagPresent, String tagValue) throws IOException {
+ List<Cell> values = new ArrayList<>();
+ TableName table = TableName.valueOf(tableName);
+ // Scan table with specified startRowKey
+ for (HRegion region :
getUtility().getHBaseCluster().getRegions(table)) {
+ values.clear();
Review comment:
nit: cleaning up entries might not be needed. If `values` has any
record, we will be out of this loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Extend Cell Tags to Delete object.
> ----------------------------------
>
> Key: PHOENIX-6213
> URL: https://issues.apache.org/jira/browse/PHOENIX-6213
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Rushabh Shah
> Assignee: Rushabh Shah
> Priority: Major
>
> We want to track the source of mutations (especially Deletes) via Phoenix. We
> have multiple use cases which does the deletes namely: customer deleting the
> data, internal process like GDPR compliance, Phoenix TTL MR jobs. For every
> mutations we want to track the source of operation which initiated the
> deletes.
> At my day job, we have custom Backup/Restore tool.
> For example: During GDPR compliance cleanup (lets say at time t0), we
> mistakenly deleted some customer data and it were possible that customer also
> deleted some data from their side (at time t1). To recover mistakenly deleted
> data, we restore from the backup at time (t0 - 1). By doing this, we also
> recovered the data that customer intentionally deleted.
> We need a way for Restore tool to selectively recover data.
> Trying to explain via an example.
> Lets say there are 2 different systems (lets say accidental-delete and
> customer-delete) deleting the data from the same table at almost the same
> time. As the name suggest customer-delete is the intentional delete and
> accidental-delete is deletes done by mistake. We have restore tool which will
> restore all the data between start time and end times (start-ts and end-ts).
> We want to restore the deletes that happened by accidental-delete system and
> not want to restore the deletes done by customer-delete system. By adding
> cell tag to Delete Markers, we can not restore data done by customer-delete
> system.
> In my proposal, I want to add cell tags to Tombstone delete marker so that we
> have that tag in the backups. Incase we have to restore data, we can restore
> specific row depending on the tag present in the cell.
> We want to leverage Cell Tag feature for Delete mutations to store these
> metadata. Currently Delete object doesn't support Tag feature.
> Also we want a solution that can be easily extensible to other mutations like
> Put.
> Some of the use cases I can think of where we can use tags for Put mutations
> are:
> 1. Identifying whether the put came from primary cluster or replicated
> cluster so that we can make the backup tool more smarter and not backup the
> same put twice in source and replicated cluster.
> 2. We have a multi-tenancy concept in Phoenix. We want to track whether the
> upsert (put operation in hbase) came from Global or Tenant connection.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
