gjacoby126 commented on a change in pull request #978:
URL: https://github.com/apache/phoenix/pull/978#discussion_r537820280



##########
File path: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java
##########
@@ -479,6 +486,10 @@ void deleteCForQ(Tuple result, List<Cell> results, 
UngroupedAggregateRegionObser
             delete.addColumns(deleteCF,  deleteCQ, ts);
             // force tephra to ignore this deletes
             
delete.setAttribute(PhoenixTransactionContext.TX_ROLLBACK_ATTRIBUTE_KEY, new 
byte[0]);
+            // TODO: We need to set SOURCE_OPERATION_ATTRIB here also. The 
control will come here if

Review comment:
       The drop column case can be a separate JIRA. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to