[
https://issues.apache.org/jira/browse/PHOENIX-6253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258400#comment-17258400
]
ASF GitHub Bot commented on PHOENIX-6253:
-----------------------------------------
stoty closed pull request #45:
URL: https://github.com/apache/phoenix-connectors/pull/45
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Change shaded connector jar naming convention
> ---------------------------------------------
>
> Key: PHOENIX-6253
> URL: https://issues.apache.org/jira/browse/PHOENIX-6253
> Project: Phoenix
> Issue Type: Improvement
> Components: connectors
> Affects Versions: connectors-6.0.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> Currently we distinguish the shaded and unshaded connector JARs by moving the
> version about. I.e phoenix5-hive-6.0.0 jar is the unshaded JAR, while
> phoenix5-6.0.0-hive.jar is the shaded one.
> This is unintuitive, and we have already dropped this convention in core.
> We could use something like:
> -phoenix5-spark-6.0.0.jar: the unshaded connector JAR-
> -phoenix5-spark-connector-6.0.0.jar : the default shaded connector JAR-
> -phoenix5-spark-connector-byo-hbase-6.0.0.jar : alternative shaded connector
> JAR.-
> phoenix5-spark-6.0.0.jar: the unshaded connector JAR
> phoenix5-spark-6.0.0-shaded.jar : the default shaded connector JAR
> phoenix5-spark-6.0.0-shaded-byo-hbase.jar : alternative shaded connector JAR.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
