[ https://issues.apache.org/jira/browse/PHOENIX-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262051#comment-17262051 ]
ASF GitHub Bot commented on PHOENIX-6211: ----------------------------------------- stoty commented on pull request #973: URL: https://github.com/apache/phoenix/pull/973#issuecomment-757400110 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 1m 30s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 16m 14s | master passed | | +1 :green_heart: | compile | 0m 58s | master passed | | +1 :green_heart: | checkstyle | 1m 47s | master passed | | +1 :green_heart: | javadoc | 0m 48s | master passed | | +0 :ok: | spotbugs | 3m 12s | phoenix-core in master has 956 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 9m 22s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | -1 :x: | checkstyle | 1m 50s | phoenix-core: The patch generated 317 new + 4854 unchanged - 133 fixed = 5171 total (was 4987) | | -1 :x: | whitespace | 0m 0s | The patch 10 line(s) with tabs. | | +1 :green_heart: | javadoc | 0m 47s | the patch passed | | -1 :x: | spotbugs | 3m 25s | phoenix-core generated 2 new + 953 unchanged - 3 fixed = 955 total (was 956) | ||| _ Other Tests _ | | -1 :x: | unit | 184m 18s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 25s | The patch does not generate ASF License warnings. | | | | 228m 19s | | | Reason | Tests | |-------:|:------| | FindBugs | module:phoenix-core | | | Should org.apache.phoenix.index.GlobalIndexChecker$GlobalIndexScanner be a _static_ inner class? At GlobalIndexChecker.java:inner class? At GlobalIndexChecker.java:[lines 128-608] | | | Boxed value is unboxed and then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:then immediately reboxed in new org.apache.phoenix.iterate.OrderedResultIterator(ResultIterator, List, boolean, long, Integer, Integer, int, long) At OrderedResultIterator.java:[line 183] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/973 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux d800b0a70da3 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 9c346ed | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/artifact/yetus-general-check/output/whitespace-tabs.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/testReport/ | | Max. process+thread count | 5980 (vs. ulimit of 30000) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-973/24/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Paged scan filters > ------------------ > > Key: PHOENIX-6211 > URL: https://issues.apache.org/jira/browse/PHOENIX-6211 > Project: Phoenix > Issue Type: Improvement > Affects Versions: 5.0.0, 4.14.3 > Reporter: Kadir OZDEMIR > Assignee: Kadir OZDEMIR > Priority: Critical > Fix For: 4.16.0 > > Attachments: PHOENIX-6211.4.x.001.patch, PHOENIX-6211.4.x.002.patch, > PHOENIX-6211.4.x.004.patch, PHOENIX-6211.4.x.005.patch, > PHOENIX-6211.4.x.006.patch, PHOENIX-6211.master.001.patch, > PHOENIX-6211.master.002.patch, PHOENIX-6211.master.003.patch, > PHOENIX-6211.master.004.patch, PHOENIX-6211.master.005.patch, > PHOENIX-6211.master.006.patch, PHOENIX-6211.master.007.patch, > PHOENIX-6211.master.008.patch, PHOENIX-6211.master.009.patch, > PHOENIX-6211.master.010.patch, PHOENIX-6211.master.011.patch > > > Phoenix performs two main operations on the server side: aggregation and > filtering. However, currently there is no internal Phoenix paging capability, > and thus server side operations can take long enough to lead to HBase client > timeouts. PHOENIX-5998 and PHOENIX-6207 are for providing the paging > capability for ungrouped and grouped aggregate operations. This improvement > Jira is for adding the paging capability for scan filters. -- This message was sent by Atlassian Jira (v8.3.4#803005)