stoty commented on pull request #1125: URL: https://github.com/apache/phoenix/pull/1125#issuecomment-770387336
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 1m 4s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 14m 57s | master passed | | +0 | hbaserecompile | 21m 43s | HBase recompiled. | | +1 :green_heart: | compile | 1m 1s | master passed | | +1 :green_heart: | checkstyle | 2m 24s | master passed | | +1 :green_heart: | javadoc | 0m 50s | master passed | | +0 :ok: | spotbugs | 3m 2s | phoenix-core in master has 954 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 8m 18s | the patch passed | | +0 | hbaserecompile | 18m 5s | HBase recompiled. | | +1 :green_heart: | compile | 1m 1s | the patch passed | | +1 :green_heart: | javac | 1m 1s | the patch passed | | -1 :x: | checkstyle | 2m 30s | phoenix-core: The patch generated 62 new + 4570 unchanged - 7 fixed = 4632 total (was 4577) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | +1 :green_heart: | javadoc | 0m 49s | the patch passed | | -1 :x: | spotbugs | 3m 15s | phoenix-core generated 2 new + 953 unchanged - 1 fixed = 955 total (was 954) | ||| _ Other Tests _ | | -1 :x: | unit | 103m 38s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 42s | The patch does not generate ASF License warnings. | | | | 160m 13s | | | Reason | Tests | |-------:|:------| | FindBugs | module:phoenix-core | | | Possible doublecheck on org.apache.phoenix.jdbc.PhoenixConnection.childConnections in org.apache.phoenix.jdbc.PhoenixConnection.addChildConnection(PhoenixConnection) At PhoenixConnection.java:org.apache.phoenix.jdbc.PhoenixConnection.addChildConnection(PhoenixConnection) At PhoenixConnection.java:[lines 471-473] | | | Nullcheck of info at line 266 of value previously dereferenced in new org.apache.phoenix.jdbc.PhoenixConnection(ConnectionQueryServices, String, Properties, PMetaData, MutationState, boolean, boolean, boolean, boolean) At PhoenixConnection.java:266 of value previously dereferenced in new org.apache.phoenix.jdbc.PhoenixConnection(ConnectionQueryServices, String, Properties, PMetaData, MutationState, boolean, boolean, boolean, boolean) At PhoenixConnection.java:[line 260] | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1125/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/1125 | | Optional Tests | dupname asflicense javac javadoc unit xml compile spotbugs hbaserebuild hbaseanti checkstyle | | uname | Linux 8bf2a1d491bd 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 22f7d41 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1125/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1125/3/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1125/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1125/3/testReport/ | | Max. process+thread count | 9260 (vs. ulimit of 30000) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1125/3/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
