[
https://issues.apache.org/jira/browse/PHOENIX-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400526#comment-17400526
]
ASF GitHub Bot commented on PHOENIX-6523:
-----------------------------------------
bharathv commented on a change in pull request #1280:
URL: https://github.com/apache/phoenix/pull/1280#discussion_r690587438
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixEmbeddedDriver.java
##########
@@ -517,20 +570,46 @@ public ConnectionInfo(String zookeeperQuorum, Integer
port, String rootNode) {
* @param other The instance to copy
*/
public ConnectionInfo(ConnectionInfo other) {
- this(other.zookeeperQuorum, other.port, other.rootNode,
other.principal, other.keytab);
+ this(other.quorum, other.port, other.rootNode, other.principal,
other.keytab);
}
public ReadOnlyProps asProps() {
Map<String, String> connectionProps =
Maps.newHashMapWithExpectedSize(3);
- if (getZookeeperQuorum() != null) {
- connectionProps.put(QueryServices.ZOOKEEPER_QUORUM_ATTRIB,
getZookeeperQuorum());
- }
- if (getPort() != null) {
- connectionProps.put(QueryServices.ZOOKEEPER_PORT_ATTRIB,
getPort().toString());
+ if (this.isHRPCBootstrap() && getQuorum() != null) {
+ final String[] masters = getQuorum().split(",");
Review comment:
+1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support for HBase Registry Implementations through Phoenix connection URL
> -------------------------------------------------------------------------
>
> Key: PHOENIX-6523
> URL: https://issues.apache.org/jira/browse/PHOENIX-6523
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Reporter: Ramie Raufdeen
> Priority: Major
>
> https://issues.apache.org/jira/browse/HBASE-23305
> https://issues.apache.org/jira/browse/HBASE-18095
>
> HBase now supports a zookeeper-less connection strategy using a Master
> Registry implementation.
>
> For this to work, the client simply needs to set a list of <host:port>s of
> the HMaster quorum
>
> {code:java}
> <property>
> <name>hbase.masters</name>
> <value>master1:16000,master2:16001,master3:16000</value>
> </property>
> {code}
>
> To support opting into this from a Phoenix connection URL, we can introduce a
> "connector type". We'll leverage the *+* char of [JDBC URL
> grammar|https://docs.oracle.com/cd/E17952_01/connector-j-8.0-en/connector-j-reference-jdbc-url-format.html]
> to specify the connection type. Connections will start to look something
> like this:
> {code:java}
> jdbc:phoenix+zk:hostname1,2,3...:<properties>
> jdbc:phoenix+hrpc:hostname1,2,3...:<properties>
> jdbc:phoenix+bigtable:hostname1,2,3...:<properties>{code}
> Above are examples of opting into hrpc/zk/bigtable registry implementations
> of HBase.
>
> If no connector is specified, the driver will default to a Zookeeper based
> connection.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
