[
https://issues.apache.org/jira/browse/PHOENIX-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17408035#comment-17408035
]
ASF GitHub Bot commented on PHOENIX-6523:
-----------------------------------------
ramatronics commented on a change in pull request #1280:
URL: https://github.com/apache/phoenix/pull/1280#discussion_r699852938
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/jdbc/PhoenixEmbeddedDriver.java
##########
@@ -225,16 +232,45 @@ private static boolean isMultiPortUrl(String portStr) {
}
return false;
}
-
+
public static ConnectionInfo create(String url) throws SQLException {
url = url == null ? "" : url;
if (url.isEmpty() || url.equalsIgnoreCase("jdbc:phoenix:")
|| url.equalsIgnoreCase("jdbc:phoenix")) {
return defaultConnectionInfo(url);
}
+
+ // ex: jdbc:phoenix+hrpc:hostname1....
url = url.startsWith(PhoenixRuntime.JDBC_PROTOCOL)
? url.substring(PhoenixRuntime.JDBC_PROTOCOL.length())
: PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + url;
+
+ HBaseRegistryBootstrapType bootstrapAsEnum = null;
+
+ // ex: +hrpc:hostname1....
+ if
(url.startsWith(String.valueOf(PhoenixRuntime.JDBC_PROTOCOL_CONNECTOR_PREFIX)))
{
+ int offset =
url.indexOf(PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR);
+ final String firstToken = url.substring(0, offset);
+
+ // ex: +hrpc
+ final String bootstrapString = firstToken
+
.replace(String.valueOf(PhoenixRuntime.JDBC_PROTOCOL_CONNECTOR_PREFIX), "")
+ .toUpperCase();
+
+ if (Strings.isNullOrEmpty(bootstrapString)) {
+ throw getMalFormedUrlException(url);
Review comment:
@stoty are you saying a URL like `+:hostname1....` is a real
possibility? I think that's a malformed string. If it was bootstrap-less it
would be `jdbc:phoenix:hostname1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support for HBase Registry Implementations through Phoenix connection URL
> -------------------------------------------------------------------------
>
> Key: PHOENIX-6523
> URL: https://issues.apache.org/jira/browse/PHOENIX-6523
> Project: Phoenix
> Issue Type: Improvement
> Components: core
> Reporter: Ramie Raufdeen
> Priority: Major
>
> https://issues.apache.org/jira/browse/HBASE-23305
> https://issues.apache.org/jira/browse/HBASE-18095
>
> HBase now supports a zookeeper-less connection strategy using a Master
> Registry implementation.
>
> For this to work, the client simply needs to set a list of <host:port>s of
> the HMaster quorum
>
> {code:java}
> <property>
> <name>hbase.masters</name>
> <value>master1:16000,master2:16001,master3:16000</value>
> </property>
> {code}
>
> To support opting into this from a Phoenix connection URL, we can introduce a
> "connector type". We'll leverage the *+* char of [JDBC URL
> grammar|https://docs.oracle.com/cd/E17952_01/connector-j-8.0-en/connector-j-reference-jdbc-url-format.html]
> to specify the connection type. Connections will start to look something
> like this:
> {code:java}
> jdbc:phoenix+zk:hostname1,2,3...:<properties>
> jdbc:phoenix+hrpc:hostname1,2,3...:<properties>
> jdbc:phoenix+bigtable:hostname1,2,3...:<properties>{code}
> Above are examples of opting into hrpc/zk/bigtable registry implementations
> of HBase.
>
> If no connector is specified, the driver will default to a Zookeeper based
> connection.
>
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
