lokiore commented on a change in pull request #1322:
URL: https://github.com/apache/phoenix/pull/1322#discussion_r725647623
##########
File path: phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java
##########
@@ -127,10 +127,16 @@
private final CompareType compareType;
private final boolean thinDriver;
private final String queryServerUrl;
+ private Properties phoenixProperties = new Properties();
@VisibleForTesting
WorkloadExecutor workloadExecutor;
+ public Pherf(String[] args, Properties phoenixProperties) throws Exception
{
Review comment:
> Why not use the existing properties field?
>
>
https://github.com/apache/phoenix/blob/1a13c055afb01a2ba6e658f0dd41a753bf904555/phoenix-pherf/src/main/java/org/apache/phoenix/pherf/Pherf.java#L113
@jpisaac existing property field is being initialised from pherf.properties,
to use the same field we will either have to pass properties some other way
(maybe one by one in arguments with some initiliazer -P), also we are passing
those properties during connection creation (not sure other properties can
affect and are not necessary ).
> There is also phoenix properties that can be specified as part of the
scenario.
For that field to use we have to predefine those properties in scenario
files, that is not helpful in case of dynamic properties selection, there are
usecases for us where we don't know conn properties beforehand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
