[ 
https://issues.apache.org/jira/browse/PHOENIX-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17428550#comment-17428550
 ] 

ASF GitHub Bot commented on PHOENIX-6572:
-----------------------------------------

yanxinyi commented on a change in pull request #1330:
URL: https://github.com/apache/phoenix/pull/1330#discussion_r728554133



##########
File path: 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -1793,9 +1811,19 @@ private MetaDataMutationResult 
metaDataCoprocessorExec(byte[] tableKey,
                         retried = true;
                         continue;
                     }
+                    success = true;
                     return MetaDataMutationResult.constructFromProto(result);
                 } finally {
-                    Closeables.closeQuietly(ht);

Review comment:
       will add this closeQuietly back




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


> Add Metrics for SystemCatalog Table
> -----------------------------------
>
>                 Key: PHOENIX-6572
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6572
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: vikas meka
>            Assignee: Xinyi Yan
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to