[
https://issues.apache.org/jira/browse/PHOENIX-5215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17430502#comment-17430502
]
ASF GitHub Bot commented on PHOENIX-5215:
-----------------------------------------
ArkenKiran commented on a change in pull request #1282:
URL: https://github.com/apache/phoenix/pull/1282#discussion_r731794647
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
##########
@@ -279,9 +281,7 @@ public void close() throws IOException {
try {
delegate.close();
} finally {
- if (child != null) {
- child.stop();
- }
+ child.end();
Review comment:
@dbwong In general opentelemetry default implementation would return an
invalid span (when telemetry is not enabled) or a valid span same goes for
startSpan as well. some other implementation might return null. I will add the
check again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove and replace HTrace
> -------------------------
>
> Key: PHOENIX-5215
> URL: https://issues.apache.org/jira/browse/PHOENIX-5215
> Project: Phoenix
> Issue Type: Bug
> Reporter: Andrew Kyle Purtell
> Assignee: Kiran Kumar Maturi
> Priority: Major
>
> HTrace is dead.
> Hadoop is discussing a replacement of HTrace with OpenTracing, see
> HADOOP-15566
> HBase is having the same discussion on HBASE-22120
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
