[ 
https://issues.apache.org/jira/browse/PHOENIX-6655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637074#comment-17637074
 ] 

Gourab Taparia edited comment on PHOENIX-6655 at 11/22/22 8:36 AM:
-------------------------------------------------------------------

[~tkhurana] [~kadir] [~gjacoby] Should we make setting of the 
CACHE_DATA_ON_WRITE flag on SYSTEM.SEQUENCE property driven ? I see few cases 
in the past(for e.g https://issues.apache.org/jira/browse/PHOENIX-4575), where 
properties were set always - and then changes had to be made to make them 
property driven as it might not be needed in all the cases ? 

I think we should also follow the same route and make CACHE_DATA_ON_WRITE flag 
controlled via a property, to give finer control on this to the end users. 
Thoughts ?


was (Author: gourab.taparia):
[~tkhurana] [~kadir] [~gjacoby] Should we make setting of the 
CACHE_DATA_ON_WRITE flag on SYSTEM.SEQUENCE property driven ? I see few cases 
in the past(for e.g https://issues.apache.org/jira/browse/PHOENIX-4575), where 
properties were set always - and then changes had to be made to make them 
property driven as it might not be needed in all the cases ? 

Should we also follow the route and make CACHE_DATA_ON_WRITE flag controlled 
via a property, to give finer control on this to the end users ? 

> SYSTEM.SEQUENCE should have CACHE_DATA_ON_WRITE set to true
> -----------------------------------------------------------
>
>                 Key: PHOENIX-6655
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6655
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Geoffrey Jacoby
>            Assignee: Gourab Taparia
>            Priority: Major
>
> High volume use cases of Phoenix sequences need to write to the same row of 
> SYSTEM.SEQUENCE very frequently, but each time we write, the block cache that 
> row is in is invalidated and has to be loaded again. 
> [~rushabh.shah] was looking at a case in our environment where a sequence was 
> being used heavily and found lots of time spent reading the HFiles for the 
> same Get of the sequence row within the SequenceRegionObserver increment 
> coproc. 
> [~apurtell] pointed out offline that HColumnDescriptor has a property, 
> CACHE_DATA_ON_WRITE that keeps caches updated when a value is flushed. This 
> should help improve contention on sequence increments. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to