[ 
https://issues.apache.org/jira/browse/PHOENIX-6395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687079#comment-17687079
 ] 

ASF GitHub Bot commented on PHOENIX-6395:
-----------------------------------------

stoty commented on PR #1560:
URL: https://github.com/apache/phoenix/pull/1560#issuecomment-1425820014

   The same question occured to me.
   
   However, when we use ServerUtil.ConnectionFactory, we are always getting the 
same Connection instance (per env), so storing the reference in the coprocessor 
instance doesn't change that, we just avoid some cache lookups.
   
   We already use ServerUtil.ConnectionFactory in a few places, I don't recall 
seeing problems stemming from this.
   
   We also use PhoenixConnections on the server side, which implement a similar 
pattern with the CQSI objects holding Connection objects being cached forever. 
(IUC we don't check or re-create those either)




> Reusing Connection instance object instead of creating everytime in 
> PhoenixAccessController class. 
> ---------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-6395
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6395
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 5.2.0, 5.1.3
>            Reporter: vikas meka
>            Assignee: Istvan Toth
>            Priority: Major
>             Fix For: 5.2.1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to