kadirozde commented on code in PR #1569:
URL: https://github.com/apache/phoenix/pull/1569#discussion_r1148447639
##########
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java:
##########
@@ -413,59 +435,81 @@ RegionScanner getWrappedScanner(final
ObserverContext<RegionCoprocessorEnvironme
dataRegion, indexMaintainer, null, viewConstants, null, null,
projector, ptr, useQualiferAsListIndex);
}
-
- /* We want to override the store scanner so that we can read "past" a delete
- marker on an SCN / lookback query to see the underlying edit. This was
possible
- in HBase 1.x, but not possible after the interface changes in HBase 2.0.
HBASE-24321 in
- HBase 2.3 gave us this ability back.
- We also need to override the flush compaction coproc hooks in order to
implement max lookback
- age to keep versions from being purged.
- */
-
+ public void setScanOptionsForFlushesAndCompactions(ScanOptions options) {
+ // We want the store to give us all the deleted cells to
StoreCompactionScanner
+ KeepDeletedCells keepDeletedCells = options.getKeepDeletedCells();
+ if (keepDeletedCells == KeepDeletedCells.FALSE) {
+ keepDeletedCells = KeepDeletedCells.TRUE;
Review Comment:
I will set it to KeepDeletedCells.TTL always regardless of what the existing
option is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
