[
https://issues.apache.org/jira/browse/PHOENIX-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708212#comment-17708212
]
ASF GitHub Bot commented on PHOENIX-6888:
-----------------------------------------
kadirozde commented on code in PR #1569:
URL: https://github.com/apache/phoenix/pull/1569#discussion_r1156724272
##########
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/CompactionScanner.java:
##########
@@ -0,0 +1,908 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.coprocessor;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.Cell;
+import org.apache.hadoop.hbase.CellComparator;
+import org.apache.hadoop.hbase.CellUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.KeepDeletedCells;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptor;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment;
+import org.apache.hadoop.hbase.regionserver.InternalScanner;
+import org.apache.hadoop.hbase.regionserver.Region;
+import org.apache.hadoop.hbase.regionserver.RegionScanner;
+import org.apache.hadoop.hbase.regionserver.ScannerContext;
+import org.apache.hadoop.hbase.regionserver.Store;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.phoenix.util.EnvironmentEdgeManager;
+import org.apache.phoenix.util.ScanUtil;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static
org.apache.phoenix.query.QueryConstants.LOCAL_INDEX_COLUMN_FAMILY_PREFIX;
+
+/**
+ * The store scanner that implements Phoenix TTL and Max Lookback. Phoenix
overrides the
+ * HBase implementation of data retention policies which is built at the cell
level, and implements
+ * its row level data retention within this store scanner.
+ */
+public class CompactionScanner implements InternalScanner {
+ private static final Logger LOGGER =
LoggerFactory.getLogger(CompactionScanner.class);
+ public static final String SEPARATOR = ":";
+ private final InternalScanner storeScanner;
+ private final Region region;
+ private final Store store;
+ private final Configuration config;
+ private final RegionCoprocessorEnvironment env;
+ private long maxLookbackWindowStart;
+ private long ttlWindowStart;
+ private long ttl;
+ private final long maxLookbackInMillis;
+ private int minVersion;
+ private int maxVersion;
+ private final boolean emptyCFStore;
+ private KeepDeletedCells keepDeletedCells;
+ private long compactionTime;
+ private final byte[] emptyCF;
+ private final byte[] emptyCQ;
+ private static Map<String, Long> maxLookbackMap = new
ConcurrentHashMap<>();
+ private PhoenixLevelRowCompactor phoenixLevelRowCompactor;
+ private HBaseLevelRowCompactor hBaseLevelRowCompactor;
+
+ public CompactionScanner(RegionCoprocessorEnvironment env,
+ Store store,
+ InternalScanner storeScanner,
+ long maxLookbackInMillis,
+ byte[] emptyCF,
+ byte[] emptyCQ) {
+ this.storeScanner = storeScanner;
+ this.region = env.getRegion();
+ this.store = store;
+ this.env = env;
+ this.emptyCF = emptyCF;
+ this.emptyCQ = emptyCQ;
+ this.config = env.getConfiguration();
+ compactionTime = EnvironmentEdgeManager.currentTimeMillis();
+ this.maxLookbackInMillis = maxLookbackInMillis;
+ String columnFamilyName = store.getColumnFamilyName();
+ String tableName = region.getRegionInfo().getTable().getNameAsString();
+ Long overriddenMaxLookback =
+ maxLookbackMap.remove(tableName + SEPARATOR +
columnFamilyName);
+ this.maxLookbackWindowStart = compactionTime - (overriddenMaxLookback
== null ?
+ maxLookbackInMillis : Math.max(maxLookbackInMillis,
overriddenMaxLookback)) - 1;
+ ColumnFamilyDescriptor cfd = store.getColumnFamilyDescriptor();
+ ttl = cfd.getTimeToLive();
+ this.ttlWindowStart = ttl == HConstants.FOREVER ? 1 : compactionTime -
ttl * 1000;
+ ttl *= 1000;
+ this.maxLookbackWindowStart = Math.max(ttlWindowStart,
maxLookbackWindowStart);
+ this.minVersion = cfd.getMinVersions();
+ this.maxVersion = cfd.getMaxVersions();
+ this.keepDeletedCells = cfd.getKeepDeletedCells();
+ emptyCFStore = region.getTableDescriptor().getColumnFamilies().length
== 1 ||
+ columnFamilyName.equals(Bytes.toString(emptyCF)) ||
+ columnFamilyName.startsWith(LOCAL_INDEX_COLUMN_FAMILY_PREFIX);
+ phoenixLevelRowCompactor = new PhoenixLevelRowCompactor();
+ hBaseLevelRowCompactor = new HBaseLevelRowCompactor();
+ }
+
+ /**
+ * Any coprocessors within a JVM can extend the max lookback window for a
column family
+ * by calling this static method.
+ */
+ public static void overrideMaxLookback(String tableName, String
columnFamilyName,
+ long maxLookbackInMillis) {
+ if (tableName == null || columnFamilyName == null) {
+ return;
+ }
+ Long old = maxLookbackMap.putIfAbsent(tableName + SEPARATOR +
columnFamilyName,
+ maxLookbackInMillis);
+ if (old != null && old < maxLookbackInMillis) {
+ maxLookbackMap.put(tableName + SEPARATOR + columnFamilyName,
maxLookbackInMillis);
+ }
+ }
+
+ @Override
+ public boolean next(List<Cell> result) throws IOException {
+ boolean hasMore = storeScanner.next(result);
+ if (!result.isEmpty()) {
+ phoenixLevelRowCompactor.compact(result, false);
+ }
+ return hasMore;
+ }
+
+ @Override
+ public boolean next(List<Cell> result, ScannerContext scannerContext)
throws IOException {
+ return next(result);
+ }
+
+ @Override
+ public void close() throws IOException {
+ storeScanner.close();
+ }
+
+ /**
+ * The context for a given row during compaction. A row may have multiple
compaction row
+ * versions. CompactionScanner uses the same row context for these
versions.
+ */
+ static class RowContext {
+ Cell familyDeleteMarker = null;
+ Cell familyVersionDeleteMarker = null;
+ List<Cell> columnDeleteMarkers = null;
+ int version = 0;
+ long maxTimestamp;
+ long minTimestamp;
+ private void addColumnDeleteMarker(Cell deleteMarker) {
+ if (columnDeleteMarkers == null) {
+ columnDeleteMarkers = new ArrayList<>();
+ }
+ columnDeleteMarkers.add(deleteMarker);
+ }
+ }
+
+ /**
+ * This method finds out the maximum and minimum timestamp of the cells of
the next row
+ * version.
+ *
+ * @param columns
+ * @param rowContext
+ */
+ private void getNextRowVersionTimestamp(LinkedList<LinkedList<Cell>>
columns,
+ RowContext rowContext) {
+ rowContext.maxTimestamp = 0;
+ rowContext.minTimestamp = Long.MAX_VALUE;
+ long ts;
+ long currentDeleteFamilyTimestamp = 0;
+ long nextDeleteFamilyTimestamp = 0;
+ boolean firstColumn = true;
+ for (LinkedList<Cell> column : columns) {
+ Cell firstCell = column.getFirst();
+ ts = firstCell.getTimestamp();
+ if (ts <= nextDeleteFamilyTimestamp) {
+ continue;
+ }
+ if (firstCell.getType() == Cell.Type.DeleteFamily ||
+ firstCell.getType() == Cell.Type.DeleteFamilyVersion) {
+ if (firstColumn) {
+ // Family delete markers are always found in the first
column of a column family
+ // When Phoenix deletes a row, it places a family delete
marker in each column
+ // family with the same timestamp. We just need to process
the delete column
+ // family markers of the first column family, which would
be in the column
+ // with columnIndex=0.
+ currentDeleteFamilyTimestamp = firstCell.getTimestamp();
+ // We need to check if the next delete family marker
exits. If so, we need
+ // to record its timestamp as by definition a compaction
row version cannot
+ // cross a family delete marker
+ if (column.size() > 1) {
+ nextDeleteFamilyTimestamp =
column.get(1).getTimestamp();
+ } else {
+ nextDeleteFamilyTimestamp = 0;
+ }
+ }
+ } else if (firstCell.getType() == Cell.Type.Put) {
+ // Row versions are constructed from put cells. So, we use only
+ // put cell timestamps to find the time range for a compaction
row version
+ if (rowContext.maxTimestamp < ts) {
+ rowContext.maxTimestamp = ts;
+ }
+ if (currentDeleteFamilyTimestamp != 0 &&
currentDeleteFamilyTimestamp < rowContext.maxTimestamp) {
+ // A compaction row version do not cross a family delete
marker. This means
+ // min timestamp cannot be lower than
currentDeleteFamilyTimestamp
+ rowContext.minTimestamp = currentDeleteFamilyTimestamp + 1;
+ } else if (rowContext.minTimestamp > ts) {
+ rowContext.minTimestamp = ts;
+ }
+ }
+ firstColumn = false;
+ }
+ }
+
+ /**
+ * HBaseLevelRowCompactor ensures that the cells of a given row are
retained according to the
+ * HBase data retention rules.
+ *
+ */
+ class HBaseLevelRowCompactor {
+ /**
+ * A compaction row version includes the latest put cell versions from
each column such that
+ * the cell versions do not cross delete family markers. In other
words, the compaction row
+ * versions are built from cell versions that are all either before or
after the next delete
+ * family or delete family version maker if family delete markers
exist. Also, when the cell
+ * timestamps are ordered for a given row version, the difference
between two subsequent
+ * timestamps has to be less than the ttl value. This is taken care
before calling
+ * HBaseLevelRowCompactor#compact().
+ *
+ * Compaction row versions are disjoint sets. A compaction row version
does not share a cell
+ * version with the next compaction row version. A compaction row
version includes at most
+ * one cell version from a column.
+ *
+ * After creating the first compaction row version, we form the next
compaction row version
+ * from the remaining cell versions.
+ *
+ * Compaction row versions are used for compaction purposes to
efficiently determine which
+ * cell versions to retain based on the HBase data retention
parameters.
+ */
+ class CompactionRowVersion {
+ // Cells included in the row version
+ List<Cell> cells = new ArrayList<>();
+ // The timestamp of the row version
+ long ts = 0;
+ // The version of a row version. It is the minimum of the versions
of the cells included
+ // in the row version
+ int version = 0;
+ @Override
+ public String toString() {
+ StringBuilder output = new StringBuilder();
+ output.append("Cell count: " + cells.size() + "\n");
+ for (Cell cell : cells) {
+ output.append(cell + "\n");
+ }
+ output.append("ts:" + ts + " v:" + version);
+ return output.toString();
+ }
+ }
+
+ /**
+ * Decide if compaction row versions inside the TTL window should be
retained. The
+ * versions are retained if one of the following conditions holds
+ * 1. The compaction row version is alive and its version is less than
VERSIONS
+ * 2. The compaction row version is deleted and KeepDeletedCells is TTL
+ * 3. The compaction row version is deleted, its version is less than
MIN_VERSIONS and
+ * KeepDeletedCells is TRUE
+ *
+ */
+ private boolean retainInsideTTLWindow(List<Cell> result,
+ CompactionRowVersion rowVersion, RowContext rowContext) {
+ if (rowContext.familyDeleteMarker == null &&
rowContext.familyVersionDeleteMarker == null) {
+ // The compaction row version is alive
+ if (rowVersion.version < maxVersion) {
+ // Rule 1
+ result.addAll(rowVersion.cells);
+ }
+ } else {
+ // Deleted
+ if ((rowVersion.version < maxVersion && keepDeletedCells ==
KeepDeletedCells.TRUE) ||
+ keepDeletedCells == KeepDeletedCells.TTL) {
+ // Retain based on rule 2 or 3
+ result.addAll(rowVersion.cells);
+ }
+ }
+ if (rowContext.familyVersionDeleteMarker != null) {
+ // Set it to null so it will be used once
+ rowContext.familyVersionDeleteMarker = null;
+ }
+ return true;
+ }
+
+ /**
+ * Decide if compaction row versions outside the TTL window should be
retained. The
+ * versions are retained if one of the following conditions holds
+ *
+ * 1. Live row versions less than MIN_VERSIONS are retained
+ * 2. Delete row versions whose delete markers are inside the TTL
window and
+ * KeepDeletedCells is TTL are retained
+ */
+ private boolean retainOutsideTTLWindow(List<Cell> result,
+ CompactionRowVersion rowVersion, RowContext rowContext) {
+ if (rowContext.familyDeleteMarker == null
+ && rowContext.familyVersionDeleteMarker == null) {
+ // Live compaction row version
+ if (rowVersion.version < minVersion) {
+ // Rule 1
+ result.addAll(rowVersion.cells);
+ }
+ } else {
+ // Deleted compaction row version
+ if (keepDeletedCells == KeepDeletedCells.TTL && (
+ (rowContext.familyVersionDeleteMarker != null &&
+
rowContext.familyVersionDeleteMarker.getTimestamp() > ttlWindowStart) ||
+ (rowContext.familyDeleteMarker != null &&
+
rowContext.familyDeleteMarker.getTimestamp() > ttlWindowStart)
+ )) {
+ // Rule 2
+ result.addAll(rowVersion.cells);
+ }
+ }
+ if (rowContext.familyVersionDeleteMarker != null) {
+ // Set it to null so it will be used once
+ rowContext.familyVersionDeleteMarker = null;
+ }
+ return true;
+ }
+
+ private boolean prepareResults(List<Cell> result, CompactionRowVersion
rowVersion,
+ RowContext rowContext) {
+ if (rowVersion.ts >= ttlWindowStart) {
+ return retainInsideTTLWindow(result, rowVersion, rowContext);
+ } else {
+ return retainOutsideTTLWindow(result, rowVersion, rowContext);
+ }
+ }
+
+ private boolean shouldRetainCell(RowContext rowContext, Cell cell) {
+ if (rowContext.columnDeleteMarkers == null) {
+ return true;
+ }
+ int i = 0;
+ for (Cell dm : rowContext.columnDeleteMarkers) {
+ if (cell.getTimestamp() > dm.getTimestamp()) {
+ continue;
+ }
+ if ((CellUtil.matchingFamily(cell, dm)) &&
+ CellUtil.matchingQualifier(cell, dm)){
+ if (dm.getType() == Cell.Type.Delete) {
+ // Delete is for deleting a specific cell version.
Thus, it can be used
+ // to delete only one cell.
+ rowContext.columnDeleteMarkers.remove(i);
+ }
+ if (maxLookbackInMillis != 0 && rowContext.maxTimestamp >=
maxLookbackWindowStart) {
+ // Inside the max lookback window
+ return true;
+ }
+ if (rowContext.maxTimestamp >= ttlWindowStart) {
+ // Outside the max lookback window but inside the TTL
window
+ if (keepDeletedCells == KeepDeletedCells.FALSE &&
+ dm.getTimestamp() < maxLookbackWindowStart ) {
+ return false;
+ }
+ return true;
+ }
+ if (keepDeletedCells == KeepDeletedCells.TTL &&
+ dm.getTimestamp() >= ttlWindowStart) {
+ return true;
+ }
+ if (maxLookbackInMillis != 0 &&
+ dm.getTimestamp() > maxLookbackWindowStart &&
rowContext.version == 0) {
+ // The delete marker is inside the max lookback window
and this is the first
+ // cell version outside the max lookback window. This
cell should be
+ // visible through the scn connection with the
timestamp >= the delete
+ // marker's timestamp
+ return true;
+ }
+ return false;
+ }
+ i++;
+ }
+ return true;
+ }
+
+ /**
+ * Form the next compaction row version by picking the first cell from
each column if the cell
+ * is not a delete marker (Type.Delete or Type.DeleteColumn) until the
first delete family or
+ * delete family version column marker is visited
+ * @param columns
+ * @param rowContext
+ * @return
+ */
+ private void formNextCompactionRowVersion(LinkedList<LinkedList<Cell>>
columns,
+ RowContext rowContext, CompactionRowVersion rowVersion) {
+ getNextRowVersionTimestamp(columns, rowContext);
+ for (LinkedList<Cell> column : columns) {
+ Cell cell = column.getFirst();
+ if (cell.getType() == Cell.Type.DeleteFamily) {
+ if (cell.getTimestamp() >= rowContext.maxTimestamp) {
+ rowContext.familyDeleteMarker = cell;
+ column.removeFirst();
+ }
+ continue;
+ }
+ else if (cell.getType() == Cell.Type.DeleteFamilyVersion) {
+ if (cell.getTimestamp() >= rowContext.maxTimestamp) {
+ rowContext.familyVersionDeleteMarker = cell;
+ column.removeFirst();
+ }
+ continue;
+ }
+ if (rowContext.maxTimestamp != 0 &&
+ column.getFirst().getTimestamp() <
rowContext.minTimestamp) {
+ continue;
+ }
+ column.removeFirst();
+ if (cell.getType() == Cell.Type.DeleteColumn ||
+ cell.getType() == Cell.Type.Delete) {
+ rowContext.addColumnDeleteMarker(cell);
+ continue;
+ }
+ if (!shouldRetainCell(rowContext, cell)) {
+ continue;
+ }
+ rowVersion.cells.add(cell);
+ }
+ rowVersion.ts = rowContext.maxTimestamp;
+ rowVersion.version = rowContext.version++;
+ }
+
+ private void formCompactionRowVersions(RowContext rowContext,
+ LinkedList<LinkedList<Cell>> columns,
+ List<Cell> result) {
+ while (!columns.isEmpty()) {
+ CompactionRowVersion compactionRowVersion = new
CompactionRowVersion();
+ formNextCompactionRowVersion(columns, rowContext,
compactionRowVersion);
+ if (!compactionRowVersion.cells.isEmpty()) {
+ prepareResults(result, compactionRowVersion, rowContext);
+ }
+ // Remove the columns that are empty
+ Iterator<LinkedList<Cell>> iterator = columns.iterator();
+ while (iterator.hasNext()) {
+ LinkedList<Cell> column = iterator.next();
+ if (column.isEmpty()) {
+ iterator.remove();
+ }
+ }
+ }
+ }
+
+ private void formColumns(List<Cell> result,
LinkedList<LinkedList<Cell>> columns,
+ List<Cell> deleteMarkers) {
+ Cell currentColumnCell = null;
+ LinkedList<Cell> currentColumn = null;
+ for (Cell cell : result) {
+ if (cell.getType() != Cell.Type.Put) {
+ deleteMarkers.add(cell);
+ }
+ if (currentColumnCell == null) {
+ currentColumn = new LinkedList<>();
+ currentColumnCell = cell;
+ currentColumn.add(cell);
+ } else if (!CellUtil.matchingQualifier(cell,
currentColumnCell)) {
+ columns.add(currentColumn);
+ currentColumn = new LinkedList<>();
+ currentColumnCell = cell;
+ currentColumn.add(cell);
+ } else {
+ currentColumn.add(cell);
+ }
+ }
+ if (currentColumn != null) {
+ columns.add(currentColumn);
+ }
+ }
+
+ /**
+ * Compacts a single row at the HBase level. The result parameter is
the input row and
+ * modified to be the output of the compaction.
+ */
+ private void compact(List<Cell> result) {
+ if (result.isEmpty()) {
+ return;
+ }
+ LinkedList<LinkedList<Cell>> columns = new LinkedList<>();
+ List<Cell> deleteMarkers = new ArrayList<>();
+ formColumns(result, columns, deleteMarkers);
+ result.clear();
+ RowContext rowContext = new RowContext();
+ formCompactionRowVersions(rowContext, columns, result);
+ // Filter delete markers
+ if (!deleteMarkers.isEmpty()) {
+ int version = 0;
+ Cell last = deleteMarkers.get(0);
+ for (Cell cell : deleteMarkers) {
+ if (cell.getType() != last.getType() ||
!CellUtil.matchingColumn(cell, last)) {
+ version = 0;
+ last = cell;
+ }
+ if (cell.getTimestamp() >= ttlWindowStart) {
+ if (keepDeletedCells == KeepDeletedCells.TTL) {
+ result.add(cell);
+ continue;
+ }
+ if (keepDeletedCells == KeepDeletedCells.TRUE) {
+ if (version < maxVersion) {
+ version++;
+ result.add(cell);
+ continue;
+ }
+ }
+ }
+ }
+ }
+ }
+ }
+
+ /**
+ * PhoenixLevelRowCompactor ensures that the cells of the latest row
version and the
+ * row versions that are visible through the max lookback window are
retained including delete
+ * cell markers placed after these cells. This is the complete set of
cells that Phoenix
+ * needs for its queries. Beyond these cells, HBase retention rules may
require more
+ * cells to be retained. These cells are identified by the HBase level
compactions implemented
+ * by HBaseLevelRowCompactor.
+ *
+ */
+ class PhoenixLevelRowCompactor {
+
+ /**
+ * The cells of the row (i.e., result) read from HBase store are
lexicographically ordered
+ * for tables using the key part of the cells which includes row,
family, qualifier,
+ * timestamp and type. The cells belong of a column are ordered from
the latest to
+ * the oldest. The method leverages this ordering and groups the cells
into their columns.
+ * The cells within the max lookback window except the once at the
lower edge of the
+ * max lookback window are retained immediately and not included in
the constructed columns.
+ */
+ private void getColumns(List<Cell> result,
LinkedList<LinkedList<Cell>> columns,
+ List<Cell> retainedCells) {
+ Cell currentColumnCell = null;
+ LinkedList<Cell> currentColumn = null;
+ for (Cell cell : result) {
+ if (cell.getTimestamp() > maxLookbackWindowStart) {
+ retainedCells.add(cell);
+ continue;
+ }
+ if (currentColumnCell == null) {
+ currentColumn = new LinkedList<>();
+ currentColumnCell = cell;
+ currentColumn.add(cell);
+ } else if (!CellUtil.matchingQualifier(cell,
currentColumnCell)) {
+ columns.add(currentColumn);
+ currentColumn = new LinkedList<>();
+ currentColumnCell = cell;
+ currentColumn.add(cell);
+ } else {
+ currentColumn.add(cell);
+ }
+ }
+ if (currentColumn != null) {
+ columns.add(currentColumn);
+ }
+ }
+
+ private void closeGap(long max, long min, List<Cell> from, List<Cell>
to) {
+ int previous = -1;
+ long ts;
+ for (Cell cell : from) {
+ ts = cell.getTimestamp();
+ if (ts >= max) {
+ previous++;
+ continue;
+ }
+ if (previous == -1) {
+ break;
+ }
+ if (max - ts > ttl) {
+ max = from.get(previous).getTimestamp();
+ to.add(from.remove(previous));
+ if (max - min > ttl) {
+ closeGap(max, min, from, to);
+ }
+ return;
+ }
+ previous++;
+ }
+ }
+
+ /**
+ * Retain the last row version visible through the max lookback window
+ */
+ private void retainCellsOfLastRowVersion(LinkedList<LinkedList<Cell>>
columns,
+ List<Cell> retainedCells) {
+ if (columns.isEmpty()) {
+ return;
+ }
+ RowContext rowContext = new RowContext();
+ getNextRowVersionTimestamp(columns, rowContext);
+ Cell firstColumnFirstCell = columns.getFirst().getFirst();
+ if (rowContext.maxTimestamp == 0 ||
+ (rowContext.maxTimestamp <=
firstColumnFirstCell.getTimestamp() &&
+ (firstColumnFirstCell.getType() == Cell.Type.DeleteFamily
||
+ firstColumnFirstCell.getType() ==
Cell.Type.DeleteFamilyVersion))) {
+ // The last row version does not exist. We will include
+ // delete markers if they are at maxLookbackWindowStart
+ for (LinkedList<Cell> column : columns) {
+ Cell cell = column.getFirst();
+ if (cell.getType() != Cell.Type.Put && cell.getTimestamp()
== maxLookbackWindowStart) {
+ retainedCells.add(cell);
+ }
+ }
+ return;
+ }
+ if (compactionTime - rowContext.maxTimestamp > maxLookbackInMillis
+ ttl) {
+ // The row version should not be visible via the max lookback
window. Nothing to do
+ return;
+ }
+ List<Cell> retainedPutCells = new ArrayList<>();
+ for (LinkedList<Cell> column : columns) {
+ Cell cell = column.getFirst();
+ if (cell.getTimestamp() < rowContext.minTimestamp) {
+ continue;
+ }
+ if (cell.getType() == Cell.Type.Put) {
+ retainedCells.add(cell);
+ retainedPutCells.add(cell);
+ }
+ }
+ // If the gap between two back to back mutations is more than ttl
then the older
+ // mutation will be considered expired and masked. If the length
of the time range of
+ // a row version is not more than ttl, then we know the cells
covered by the row
+ // version are not apart from each other more than ttl and will
not be masked.
+ if (rowContext.maxTimestamp - rowContext.minTimestamp <= ttl) {
+ return;
+ }
+ // The quick time range check did not pass. We need get at least
one empty cell to cover
+ // the gap so that the row version will not be masked by
PhoenixTTLRegionScanner.
+ List<Cell> emptyCellColumn = null;
+ for (LinkedList<Cell> column : columns) {
+ if (ScanUtil.isEmptyColumn(column.getFirst(), emptyCF,
emptyCQ)) {
+ emptyCellColumn = column;
+ break;
+ }
+ }
+ if (emptyCellColumn == null) {
+ return;
+ }
+ int size = retainedPutCells.size();
+ long tsArray[] = new long[size];
+ int i = 0;
+ for (Cell cell : retainedPutCells) {
+ tsArray[i++] = cell.getTimestamp();
+ }
+ Arrays.sort(tsArray);
+ for (i = size - 1; i > 0; i--) {
+ if (tsArray[i] - tsArray[i - 1] > ttl) {
+ closeGap(tsArray[i], tsArray[i - 1], emptyCellColumn,
retainedCells);
+ }
+ }
+ }
+
+ private boolean retainCellsForMaxLookback(List<Cell> result, boolean
regionLevel,
+ List<Cell> retainedCells) {
+ LinkedList<LinkedList<Cell>> columns = new LinkedList<>();
+ getColumns(result, columns, retainedCells);
+ long maxTimestamp = 0;
+ long minTimestamp = Long.MAX_VALUE;
+ long ts;
+ for (LinkedList<Cell> column : columns) {
+ ts = column.getFirst().getTimestamp();
+ if (ts > maxTimestamp) {
+ maxTimestamp = ts;
+ }
+ ts = column.getLast().getTimestamp();
+ if (ts < minTimestamp) {
+ minTimestamp = ts;
+ }
+ }
+ if (compactionTime - maxTimestamp > maxLookbackInMillis + ttl) {
+ if (!emptyCFStore && !regionLevel) {
+ // The row version is more than maxLookbackInMillis + ttl
old. We cannot decide
+ // if we should retain it with the store level compaction
when the current
+ // store is not the empty column family store.
+ return false;
+ }
+ }
+ // The gap between two back to back mutations if more than ttl
then we know that the row
+ // is expired before the newer mutation.
+ if (maxTimestamp - minTimestamp > ttl) {
+ if (!emptyCFStore && !regionLevel) {
+ // We need empty column cells to decide which cells to
retain
+ return false;
+ }
+ int size = result.size();
+ long tsArray[] = new long[size];
+ int i = 0;
+ for (Cell cell : result) {
+ tsArray[i++] = cell.getTimestamp();
+ }
+ Arrays.sort(tsArray);
+ for (i = size - 1; i > 0; i--) {
+ if (tsArray[i] - tsArray[i - 1] > ttl) {
+ minTimestamp = tsArray[i];
+ break;
+ }
+ }
+ List<Cell> trimmedResult = new ArrayList<>(size - i);
+ for (Cell cell : result) {
+ if (cell.getTimestamp() >= minTimestamp) {
+ trimmedResult.add(cell);
+ }
+ }
+ columns.clear();
+ retainedCells.clear();
+ getColumns(trimmedResult, columns, retainedCells);
+ }
+ retainCellsOfLastRowVersion(columns, retainedCells);
+ return true;
+ }
+ /**
+ * Compacts a single row at the Phoenix level. The result parameter is
the input row and
+ * modified to be the output of the compaction process.
+ */
+ private void compact(List<Cell> result, boolean regionLevel) throws
IOException {
+ if (result.isEmpty()) {
+ return;
+ }
+ List<Cell> phoenixResult = new ArrayList<>(result.size());
+ if (!retainCellsForMaxLookback(result, regionLevel,
phoenixResult)) {
+ if (emptyCFStore || regionLevel) {
+ throw new RuntimeException("UNEXPECTED");
+ }
+ phoenixResult.clear();
+ compactRegionLevel(result, phoenixResult);
+ }
+ if (maxVersion == 1 && minVersion == 0 && keepDeletedCells ==
KeepDeletedCells.FALSE) {
+ // We need to Phoenix level compaction only
+ Collections.sort(phoenixResult, CellComparator.getInstance());
+ result.clear();
+ result.addAll(phoenixResult);
+ return;
+ }
+ // We may need to do retain more cells, and so we need to run
HBase level compaction
+ // too. The result of two compactions will be merged and duplicate
cells are removed.
+ int phoenixResultSize = phoenixResult.size();
+ List<Cell> hbaseResult = new ArrayList<>(result);
+ hBaseLevelRowCompactor.compact(hbaseResult);
+ phoenixResult.addAll(hbaseResult);
+ Collections.sort(phoenixResult, CellComparator.getInstance());
+ result.clear();
+ Cell previousCell = null;
+ for (Cell cell : phoenixResult) {
+ if (previousCell == null ||
+ CellComparator.getInstance().compare(cell,
previousCell) != 0) {
+ result.add(cell);
+ }
+ previousCell = cell;
+ }
+ if (result.size() > phoenixResultSize) {
+ LOGGER.debug("HBase level compaction retained " +
+ (result.size() - phoenixResultSize) + " more cells");
+ }
+ }
+
+ private int compareQualifiers(Cell a, Cell b) {
+ return Bytes.compareTo(a.getQualifierArray(),
a.getQualifierOffset(),
+ a.getQualifierLength(),
+ b.getQualifierArray(), b.getQualifierOffset(),
a.getQualifierLength());
+ }
+
+ private int compareTypes(Cell a, Cell b) {
Review Comment:
I simplified trimRegionResult.
> Fixing TTL and Max Lookback Issues for Phoenix Tables
> -----------------------------------------------------
>
> Key: PHOENIX-6888
> URL: https://issues.apache.org/jira/browse/PHOENIX-6888
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.1.3
> Reporter: Kadir Ozdemir
> Assignee: Kadir Ozdemir
> Priority: Major
>
> In HBase, the unit of data is a cell and data retention rules are executed at
> the cell level. These rules are defined at the column family level. Phoenix
> leverages the data retention features of HBase and exposes them to its users
> to provide its TTL feature at the table level. However, these rules (since
> they are defined at the cell level instead of the row level) results in
> partial row retention that in turn creates data integrity issues at the
> Phoenix level.
> Similarly, Phoenix’s max lookback feature leverages HBase deleted data
> retention capabilities to preserve deleted cells within a configurable max
> lookback. This requires two data retention windows, max lookback and TTL. One
> end of these windows is the current time and the end is a moment in the past
> (i.e., current time minus the window size). Typically, the max lookback
> window is shorter than the TTL window. In the max lookback window, we would
> like to preserve the complete history of mutations regardless of how many
> cell versions these mutations generated. In the remaining TTL window outside
> the max lookback, we would like to apply the data retention rules defined
> above. However, HBase provides only one data retention window. Thus, the max
> lookback window had to be extended to become TTL window and the max lookback
> feature results in unwantedly retaining deleted data for the maximum of max
> lookback and TTL periods.
> This Jira is to fix both of these issues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
