virajjasani commented on code in PR #1598:
URL: https://github.com/apache/phoenix/pull/1598#discussion_r1185644525
##########
phoenix-core/src/main/antlr3/PhoenixSQL.g:
##########
@@ -452,7 +454,14 @@ oneStatement returns [BindableStatement ret]
finally{ contextStack.pop(); }
explain_node returns [BindableStatement ret]
- : EXPLAIN q=oneStatement {$ret=factory.explain(q);}
+ : EXPLAIN (w=WITH)? (r=REGIONS)? q=oneStatement
Review Comment:
Sounds good, let me try this tomorrow i.e. let the source generate all info
in the explain plan including region info, but it's upto
`ExecutableExplainStatement` to control what to print.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
