[
https://issues.apache.org/jira/browse/PHOENIX-6907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719586#comment-17719586
]
ASF GitHub Bot commented on PHOENIX-6907:
-----------------------------------------
virajjasani commented on code in PR #1598:
URL: https://github.com/apache/phoenix/pull/1598#discussion_r1185644525
##########
phoenix-core/src/main/antlr3/PhoenixSQL.g:
##########
@@ -452,7 +454,14 @@ oneStatement returns [BindableStatement ret]
finally{ contextStack.pop(); }
explain_node returns [BindableStatement ret]
- : EXPLAIN q=oneStatement {$ret=factory.explain(q);}
+ : EXPLAIN (w=WITH)? (r=REGIONS)? q=oneStatement
Review Comment:
Sounds good, let me try this tomorrow i.e. let the source generate all info
in the explain plan including region info, but it's upto
`ExecutableExplainStatement` to control what to print.
> Explain Plan should output region locations with servers
> --------------------------------------------------------
>
> Key: PHOENIX-6907
> URL: https://issues.apache.org/jira/browse/PHOENIX-6907
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.2.0, 5.1.4
>
>
> As of today, explain plan provides details related to scan key range size,
> size of the scan lists (for parallel scans), hints, client/server sorted by,
> order by, server filter etc. It provides as much close details to the
> physical plans as possible.
> If we could also make explain plan output to include region locations that
> also contains regionserver details on which the region is currently residing,
> this might turn out to be really good insights. For full table scans, this
> also means that we would end up including very higher number of region
> locations and it would not be ideal to print all of them in the output. We
> can enforce a limit on the num of region locations to print (default value
> could be 10 or so). For point lookup and range scans, we can find the region
> locations with regionserver as quite useful for the real time analysis of
> slowness experienced by the given query.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
