[
https://issues.apache.org/jira/browse/PHOENIX-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770101#comment-17770101
]
ASF GitHub Bot commented on PHOENIX-7055:
-----------------------------------------
stoty commented on code in PR #1695:
URL: https://github.com/apache/phoenix/pull/1695#discussion_r1340287215
##########
bin/sqlline.py:
##########
@@ -114,6 +116,7 @@ def kill_child():
disable_jna = ""
java_cmd = java + ' $PHOENIX_OPTS ' + \
+ (args.debug and
"-Xrunjdwp:transport=dt_socket,server=y,suspend=n,address=127.0.0.1:8071" or
"") + \
Review Comment:
This is not really useful for end users.
Developers should be able to set this in PHOENIX_OPTS themseves as needed
> Usage improvements for sqline.py
> --------------------------------
>
> Key: PHOENIX-7055
> URL: https://issues.apache.org/jira/browse/PHOENIX-7055
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Hari Krishna Dara
> Assignee: Hari Krishna Dara
> Priority: Major
>
> A few small improvements to make the usage of this tool easier:
> * It should be possible to start sqline without making a connection. This
> useful to open a custom connection from the prompt and also simply browse
> through the history.
> * Start in debug mode so that we can connect from a debug client.
> * Fix bugs in the existing boolean option interpretations
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
