[ https://issues.apache.org/jira/browse/PHOENIX-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17770960#comment-17770960 ]
ASF GitHub Bot commented on PHOENIX-6523: ----------------------------------------- stoty commented on code in PR #1658: URL: https://github.com/apache/phoenix/pull/1658#discussion_r1342282891 ########## phoenix-core/src/main/java/org/apache/phoenix/jdbc/MasterConnectionInfo.java: ########## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.jdbc; + +import java.sql.SQLException; +import java.util.Map; +import java.util.Properties; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.HConstants; +import org.apache.hadoop.hbase.security.User; +import org.apache.phoenix.util.PhoenixRuntime; +import org.apache.phoenix.util.ReadOnlyProps; + +/** + * ConnectionInfo used for org.apache.hadoop.hbase.client.MasterRegistry + * + */ +public class MasterConnectionInfo extends AbstractRPCConnectionInfo { + + private static final String MASTER_REGISTRY_CLASS_NAME = + "org.apache.hadoop.hbase.client.MasterRegistry"; Review Comment: Opened PHOENIX-7059 for the constant de-duplication. > Support for HBase Registry Implementations through Phoenix connection URL > ------------------------------------------------------------------------- > > Key: PHOENIX-6523 > URL: https://issues.apache.org/jira/browse/PHOENIX-6523 > Project: Phoenix > Issue Type: Improvement > Components: core > Reporter: Ramie Raufdeen > Assignee: Istvan Toth > Priority: Major > > https://issues.apache.org/jira/browse/HBASE-23305 > https://issues.apache.org/jira/browse/HBASE-18095 > > HBase now supports a zookeeper-less connection strategy using a Master > Registry implementation. > > For this to work, the client simply needs to set a list of <host:port>s of > the HMaster quorum > > {code:java} > <property> > <name>hbase.masters</name> > <value>master1:16000,master2:16001,master3:16000</value> > </property> > {code} > > To support opting into this from a Phoenix connection URL, we can introduce a > "connector type". We'll leverage the *+* char of [JDBC URL > grammar|https://docs.oracle.com/cd/E17952_01/connector-j-8.0-en/connector-j-reference-jdbc-url-format.html] > to specify the connection type. Connections will start to look something > like this: > {code:java} > jdbc:phoenix+zk:hostname1,2,3...:<properties> > jdbc:phoenix+hrpc:hostname1,2,3...:<properties> > jdbc:phoenix+bigtable:hostname1,2,3...:<properties>{code} > Above are examples of opting into hrpc/zk/bigtable registry implementations > of HBase. > > If no connector is specified, the driver will default to a Zookeeper based > connection. > > > -- This message was sent by Atlassian Jira (v8.20.10#820010)