haridsv commented on code in PR #1713:
URL: https://github.com/apache/phoenix/pull/1713#discussion_r1371761534
##########
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java:
##########
@@ -3545,6 +3545,18 @@ public MutationState dropIndex(DropIndexStatement
statement) throws SQLException
return dropTable(schemaName, tableName, parentTableName,
PTableType.INDEX, statement.ifExists(), false, false);
}
+ public MutationState dropCDC(DropCDCStatement statement) throws
SQLException {
+ String schemaName = statement.getTableName().getSchemaName();
+ String cdcTableName = statement.getCdcObjName().getName();
+ String parentTableName = statement.getTableName().getTableName();
+ // Dropping the virtual CDC Table
+ dropTable(schemaName, cdcTableName, parentTableName, PTableType.CDC,
statement.ifExists(), false, false);
+
+ String indexName =
CDCUtil.getCDCIndexName(statement.getCdcObjName().getName());
+ // Dropping the uncovered index associated with the CDC Table
+ return dropTable(schemaName, indexName, parentTableName,
PTableType.INDEX, statement.ifExists(), false, false);
Review Comment:
> underscores in the beginning which is preventing the index to be dropped
directly.
You can still drop it by putting double quotes around the index name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
