[ https://issues.apache.org/jira/browse/PHOENIX-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792039#comment-17792039 ]
ASF GitHub Bot commented on PHOENIX-6053: ----------------------------------------- Aarchy commented on code in PR #1690: URL: https://github.com/apache/phoenix/pull/1690#discussion_r1412066252 ########## phoenix-tests/src/test/java/org/apache/phoenix/util/ServerUtilTest.java: ########## @@ -45,13 +45,13 @@ public class ServerUtilTest { @Test public void testIsHbaseNamespaceAvailableWithExistingNamespace() throws Exception { Admin mockAdmin = getMockedAdmin(); - assertTrue(ServerUtil.isHBaseNamespaceAvailable(mockAdmin, existingNamespaceOne)); + assertTrue(ClientUtil.isHBaseNamespaceAvailable(mockAdmin, existingNamespaceOne)); Review Comment: Fortunately this test class only contains tests for ClientUtil, so I will just rename it to ClientUtilTest. > Use shaded hadoop-client and hbase-shaded-client in phoenix-client > ------------------------------------------------------------------ > > Key: PHOENIX-6053 > URL: https://issues.apache.org/jira/browse/PHOENIX-6053 > Project: Phoenix > Issue Type: Improvement > Components: core > Affects Versions: 5.1.0 > Reporter: Istvan Toth > Assignee: Aron Attila Meszaros > Priority: Major > Attachments: Phoenix_separation.pdf > > > The phoenix client is built with the unshaded Hadoop and HBase dependencies, > and then relocates some (a lot) of those to declutter the client classpath. > Try to use hadoop-client and hbase-shaded-client-byo-hadoop instead. (And > keep relocating our direct dependecies) > While this will likely further bloat the thick client JAR, it should > * clean up the classpath further > * Would decouple most of the dependencies that Phoenix shares with > Hbase/Hadoop from them. -- This message was sent by Atlassian Jira (v8.20.10#820010)