richardantal commented on code in PR #1690:
URL: https://github.com/apache/phoenix/pull/1690#discussion_r1412158994
##########
phoenix-coprocessors/src/main/java/org/apache/phoenix/coprocessor/UncoveredIndexRegionScanner.java:
##########
@@ -321,10 +324,12 @@ private boolean getNextCoveredIndexRow(List<Cell> result)
throws IOException {
}
} else {
if (indexMaintainer.isUncovered()) {
+ long ts = indexRow.get(0).getTimestamp();
// Since we also scan the empty column for uncovered
global indexes, this mean the data row
// does not exist. Delete the index row if the index
is an uncovered global index
- indexMaintainer.deleteRowIfAgedEnough(indexRowKey,
indexRow.get(0).getTimestamp(),
- ageThreshold, false, region);
+ if (indexMaintainer.isAgedEnough(ts, ageThreshold)) {
+
region.delete(indexMaintainer.createDelete(indexRowKey, ts, false));
Review Comment:
yep, that is right, that should do the same.
I was curious if you know if there is some performance difference between
the 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
