jpisaac commented on code in PR #1710:
URL: https://github.com/apache/phoenix/pull/1710#discussion_r1412637207
##########
phoenix-core/src/main/java/org/apache/phoenix/util/ViewUtil.java:
##########
@@ -132,20 +134,35 @@ public static Pair<List<PTable>, List<TableInfo>>
findAllDescendantViews(
List<PTable> legitimateChildViews = new ArrayList<>();
List<TableInfo> orphanChildViews = new ArrayList<>();
- findAllDescendantViews(sysCatOrsysChildLink, serverSideConfig,
tenantId, schemaName,
+ return findAllDescendantViews(sysCatOrsysChildLink, serverSideConfig,
tenantId, schemaName,
tableOrViewName, clientTimeStamp, legitimateChildViews,
orphanChildViews,
findJustOneLegitimateChildView);
- return new Pair<>(legitimateChildViews, orphanChildViews);
}
- private static void findAllDescendantViews(Table sysCatOrsysChildLink,
- Configuration serverSideConfig, byte[] parentTenantId, byte[]
parentSchemaName,
- byte[] parentTableOrViewName, long clientTimeStamp, List<PTable>
legitimateChildViews,
- List<TableInfo> orphanChildViews, boolean
findJustOneLegitimateChildView)
+ public static Pair<List<PTable>, List<TableInfo>>
findAllDescendantViews(Table sysCatOrsysChildLink,
+ Configuration serverSideConfig, byte[] parentTenantId, byte[]
parentSchemaName,
+ byte[] parentTableOrViewName, long clientTimeStamp, List<PTable>
legitimateChildViews,
+ List<TableInfo> orphanChildViews, boolean
findJustOneLegitimateChildView)
+ throws IOException, SQLException{
+
+ return findAllDescendantViews(sysCatOrsysChildLink, null,
serverSideConfig,
+ parentTenantId, parentSchemaName, parentTableOrViewName,
clientTimeStamp,
+ legitimateChildViews, orphanChildViews,
findJustOneLegitimateChildView,
+ new Pair<>(false, false));
+
+ }
+
Review Comment:
nit: Can u add some comments for the new methods and hierarchy traversal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
