NihalJain commented on code in PR #1760: URL: https://github.com/apache/phoenix/pull/1760#discussion_r1425918182
########## phoenix-tracing-webapp/src/main/config/checkstyle/checker.xml: ########## @@ -27,8 +27,8 @@ limitations under the License. --> <!DOCTYPE module PUBLIC - "-//Puppy Crawl//DTD Check Configuration 1.3//EN" - "http://www.puppycrawl.com/dtds/configuration_1_3.dtd";> + "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" Review Comment: its possible this may fix it as we were using http before and now it changes to https as mentioned by someone in https://stackoverflow.com/questions/44333939/the-markup-declarations-contained-or-pointed-to-by-the-document-type-declaration. also possible this check was never passing? lets see what build says -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
