[ https://issues.apache.org/jira/browse/PHOENIX-7130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802201#comment-17802201 ]
ASF GitHub Bot commented on PHOENIX-7130: ----------------------------------------- NihalJain commented on PR #1745: URL: https://github.com/apache/phoenix/pull/1745#issuecomment-1875472586 > I have tested this now, but the shading time difference is seems to be minimal. On my machine it takes ~3:20 with the shaded sources, and ~3:05 without them. In our internal jenkins, which is based on branch-5.1, the difference is substantial. Maybe because we download all jars for every build and also possibly our local artifactory + VPN is not as fast, so downloading the source jars take almost 33% of build time. Without `-PskipShadeSources -Dmaven.source.skip=true` ``` . . [INFO] Phoenix Client ..................................... SUCCESS [22:40 min] [INFO] Phoenix Client Embedded ............................ SUCCESS [08:56 min] [INFO] Phoenix Server JAR ................................. SUCCESS [01:54 min] [INFO] Phoenix Assembly ................................... SUCCESS [ 38.548 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 36:06 min [INFO] Finished at: 2024-01-03T10:55:52Z [INFO] ------------------------------------------------------------------------ ``` Vs With `-PskipShadeSources -Dmaven.source.skip=true` ``` . . [INFO] Phoenix Client ..................................... SUCCESS [09:37 min] [INFO] Phoenix Client Embedded ............................ SUCCESS [08:14 min] [INFO] Phoenix Server JAR ................................. SUCCESS [01:49 min] [INFO] Phoenix Assembly ................................... SUCCESS [ 38.593 s] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 24:08 min [INFO] Finished at: 2024-01-03T11:29:24Z [INFO] ------------------------------------------------------------------------ ``` > Also I have just merged phoenix-client-lite, you may want to update the patch to add same change there. Sure let me rebase and make appropriate changes, if any > Support skipping of shade sources jar creation > ---------------------------------------------- > > Key: PHOENIX-7130 > URL: https://issues.apache.org/jira/browse/PHOENIX-7130 > Project: Phoenix > Issue Type: Improvement > Components: phoenix > Reporter: Nihal Jain > Assignee: Nihal Jain > Priority: Minor > Labels: build > > Shade sources jar creation takes a lot of time and we do not want to do this > for every dev build (in our internal phoenix jenkins). Hence with this Jira, > will add a profile to disable shade jar creation optionally by running with > '-PskipShadeSources'. -- This message was sent by Atlassian Jira (v8.20.10#820010)