kadirozde commented on code in PR #1780: URL: https://github.com/apache/phoenix/pull/1780#discussion_r1445931236
########## phoenix-core-client/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java: ########## @@ -641,19 +710,32 @@ public <T> T accept(ExpressionVisitor<T> visitor) { return null; } } - private static void serailizeArrayIndexInformationAndSetInScan(StatementContext context, List<Expression> arrayKVFuncs, - List<KeyValueColumnExpression> arrayKVRefs) { + + static class JsonPathExpression extends ArrayIndexExpression { Review Comment: This inheritance relationship does not sound right to me. Can we introduce an abstract class both JsonPathExpression and ArrayIndexExpression can extend or something similar? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org