[ 
https://issues.apache.org/jira/browse/PHOENIX-6166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17816163#comment-17816163
 ] 

ASF GitHub Bot commented on PHOENIX-6166:
-----------------------------------------

stoty commented on PR #130:
URL: 
https://github.com/apache/phoenix-connectors/pull/130#issuecomment-1936321885

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   6m 16s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |  10m 17s |  Maven dependency ordering for branch  |
   | -1 :x: |  mvninstall  |   0m  8s |  root in master failed.  |
   | -1 :x: |  compile  |   0m  8s |  phoenix5-hive in master failed.  |
   | -1 :x: |  compile  |   0m  9s |  phoenix5-spark in master failed.  |
   | -1 :x: |  compile  |   0m  8s |  phoenix5-spark3 in master failed.  |
   | -1 :x: |  javadoc  |   0m  9s |  phoenix5-hive in master failed.  |
   | -1 :x: |  javadoc  |   0m  9s |  phoenix5-spark in master failed.  |
   | -1 :x: |  javadoc  |   0m  9s |  phoenix5-spark3 in master failed.  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m  9s |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m  6s |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m  9s |  phoenix5-hive in the patch failed.  |
   | -1 :x: |  compile  |   0m  8s |  phoenix5-spark in the patch failed.  |
   | -1 :x: |  compile  |   0m  8s |  phoenix5-spark3 in the patch failed.  |
   | -1 :x: |  javac  |   0m  9s |  phoenix5-hive in the patch failed.  |
   | -1 :x: |  javac  |   0m  8s |  phoenix5-spark in the patch failed.  |
   | -1 :x: |  javac  |   0m  8s |  phoenix5-spark3 in the patch failed.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  4s |  The patch has no ill-formed XML 
file.  |
   | -1 :x: |  javadoc  |   0m  9s |  phoenix5-hive in the patch failed.  |
   | -1 :x: |  javadoc  |   0m  9s |  phoenix5-spark in the patch failed.  |
   | -1 :x: |  javadoc  |   0m  9s |  phoenix5-spark3 in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m 10s |  phoenix5-hive in the patch failed.  |
   | -1 :x: |  unit  |   0m  8s |  phoenix5-spark in the patch failed.  |
   | -1 :x: |  unit  |   0m  9s |  phoenix5-spark3 in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 31s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  20m 11s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.44 ServerAPI=1.44 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix-connectors/pull/130 |
   | Optional Tests | dupname asflicense javac javadoc unit xml compile |
   | uname | Linux 2eec73f7b6ce 5.15.0-88-generic #98-Ubuntu SMP Mon Oct 2 
15:18:56 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-connectors-personality.sh |
   | git revision | master / 6d57726 |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
 |
   | compile | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/branch-compile-phoenix5-hive.txt
 |
   | compile | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/branch-compile-phoenix5-spark.txt
 |
   | compile | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/branch-compile-phoenix5-spark3.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-hive.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/branch-javadoc-phoenix5-spark3.txt
 |
   | mvninstall | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
 |
   | compile | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-compile-phoenix5-hive.txt
 |
   | compile | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
 |
   | compile | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
 |
   | javac | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-compile-phoenix5-hive.txt
 |
   | javac | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark.txt
 |
   | javac | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-compile-phoenix5-spark3.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-hive.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-javadoc-phoenix5-spark3.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-unit-phoenix5-hive.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-unit-phoenix5-spark.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/artifact/yetus-general-check/output/patch-unit-phoenix5-spark3.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/testReport/
 |
   | Max. process+thread count | 52 (vs. ulimit of 30000) |
   | modules | C: phoenix5-hive phoenix5-spark phoenix5-spark3 U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-130/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Make Tephra support optional for phoenix 5 connectors
> -----------------------------------------------------
>
>                 Key: PHOENIX-6166
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6166
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: connectors
>    Affects Versions: connectors-6.0.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> We should add an option to trigger the same optional exclusion that 
> PHOENIX-6064 added for the core components.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to